[Maps] fix vector tile load errors not displayed in legend by nreese · Pull Request #130395 · elastic/kibana

nreese · 2022-04-15T15:37:25Z

Fixes #130199

Return elasticsearch error code to client. Display tile errors in UI

elasticmachine · 2022-04-15T16:37:51Z

Pinging @elastic/kibana-gis (Team:Geo)

nreese · 2022-04-15T16:48:07Z

@elasticmachine merge upstream

…-fix'

…0199

…-fix'

…0199

kibana-ci · 2022-04-18T15:44:03Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`maps`	2.6MB	2.6MB	+1.5KB

History

💚 Build #38499 succeeded 3c2c30d
💔 Build #38477 failed 8511b5e
💔 Build #38466 failed 5eb5788
💔 Build #38454 failed 6379b8f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

nickpeihl

lgtm!

code review and tested in chrome

nickpeihl · 2022-04-18T15:01:06Z

x-pack/plugins/maps/public/connected_components/mb_map/tile_status_tracker.ts

+   * Clear errors when center tile changes.
+   * Tracking center tile provides the cleanest way to know when a new data fetching cycle is beginning
+   */


This is clever!

nickpeihl · 2022-04-18T18:58:52Z

x-pack/plugins/maps/server/mvt/mvt_routes.test.ts

+  });
+});
+
+test('should not set content-encoding when elasticsearch does not provide value', () => {


thanks for providing these tests! 👍

TinaHeiligers · 2022-04-18T19:38:36Z

src/core/server/server.api.md

        attributes?: ResponseErrorAttributes | undefined;
    }>;
-    customError: (options: CustomHttpResponseOptions<ResponseError>) => KibanaResponse<string | Error | {
+    customError: (options: CustomHttpResponseOptions<ResponseError | Buffer | Stream>) => KibanaResponse<string | Error | Buffer | Stream | {


Looks ok to me, although as a nit, it would probably be good to add a note that explains the implications of using a Buffer or Stream as a customError

it would probably be good to add a note that explains the implications of using a Buffer or Stream as a customError

Can you add more details about what to add?

* [Maps] fix vector tile load errors not displayed in legend * revert unneeded change * update API docs * add error integration test * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * eslint and fix jest test * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * cleanup Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit fa89c45)

kibanamachine · 2022-04-18T22:24:53Z

💚 All backports created successfully

Status	Branch	Result
✅	8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…0395) (#130514) * [Maps] fix vector tile load errors not displayed in legend (#130395) * [Maps] fix vector tile load errors not displayed in legend * revert unneeded change * update API docs * add error integration test * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * eslint and fix jest test * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * cleanup Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit fa89c45) * fix import Co-authored-by: Nathan Reese <reese.nathan@elastic.co>

…disable-server-side * 'main' of github.com:elastic/kibana: (103 commits) [Osquery] Update eslint config (elastic#129637) [Uptime] Update monitor saved object mappings (elastic#130433) Add links to metricbeat module docs (elastic#130519) Add link to troubleshooting guide in confirm data copy (elastic#130420) [Step 3] Cleanup charts plugin (elastic#130132) [Visualize] Adds a deprecation warning to the pie app (elastic#130447) [Maps] fix vector tile load errors not displayed in legend (elastic#130395) [CI] Split alerting-api-integration tests into separate cigroups (elastic#130414) [CI] Use spot instances for default cigroups in PR CI (elastic#130476) [functional-tests] TimePicker optimizations (elastic#130200) [kbn/pm] use stable module ids in dist (elastic#130497) [8.2.1][Security Solution][Session view] fix full screen session view margin (elastic#130496) Fix wrong config in comments (elastic#130378) Add deprecated telemetry (elastic#130458) Add eslint rule to support breaking up packages (elastic#130483) [Security Solution][Endpoint] Fix test stability and un-skip flaky tests (elastic#130176) Update object types for SharePoint Online external connector (elastic#130478) [Workplace Search] Fix broken feedback link (elastic#130475) Rename the term "execution" in config to "run" (elastic#130172) [Cloud Posture] use index with keyword mapping (elastic#130456) ... # Conflicts: # docs/user/reporting/index.asciidoc # x-pack/plugins/reporting/public/types.ts # x-pack/plugins/screenshotting/server/screenshots/index.test.ts # x-pack/plugins/screenshotting/server/screenshots/index.ts

…30395) * [Maps] fix vector tile load errors not displayed in legend * revert unneeded change * update API docs * add error integration test * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * eslint and fix jest test * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * cleanup Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

[Maps] fix vector tile load errors not displayed in legend

d1d53d7

nreese added Team:Geo Former Team Label for Geo Team. Now use Team:Presentation auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 v8.3.0 release_note:fix labels Apr 15, 2022

nreese added 3 commits April 15, 2022 09:41

revert unneeded change

6379b8f

update API docs

5eb5788

add error integration test

c512571

nreese marked this pull request as ready for review April 15, 2022 16:37

nreese requested review from a team as code owners April 15, 2022 16:37

nreese requested a review from thomasneirynck April 15, 2022 16:37

kibanamachine and others added 8 commits April 15, 2022 11:48

Merge branch 'main' into issue_130199

4744a39

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

8511b5e

…-fix'

eslint and fix jest test

e698be0

Merge branch 'issue_130199' of github.com:nreese/kibana into issue_13…

c936c06

…0199

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

3c2c30d

…-fix'

merge with main and add unit test

3dc31b6

Merge branch 'issue_130199' of github.com:nreese/kibana into issue_13…

15aceab

…0199

cleanup

21c19fb

nickpeihl approved these changes Apr 18, 2022

View reviewed changes

TinaHeiligers approved these changes Apr 18, 2022

View reviewed changes

nreese merged commit fa89c45 into elastic:main Apr 18, 2022

kibanamachine mentioned this pull request Apr 18, 2022

[8.2] [Maps] fix vector tile load errors not displayed in legend (#130395) #130514

Merged

This was referenced May 3, 2022

Test(s) needed for [Maps] Use content-encoding header from ES for mvt response #131445

Closed

[Maps] Use content-encoding header from ES for mvt response #130417

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Maps] fix vector tile load errors not displayed in legend#130395

[Maps] fix vector tile load errors not displayed in legend#130395
nreese merged 12 commits intoelastic:mainfrom
nreese:issue_130199

nreese commented Apr 15, 2022

Uh oh!

elasticmachine commented Apr 15, 2022

Uh oh!

nreese commented Apr 15, 2022

Uh oh!

kibana-ci commented Apr 18, 2022

Uh oh!

nickpeihl left a comment

Uh oh!

nickpeihl Apr 18, 2022

Uh oh!

nickpeihl Apr 18, 2022

Uh oh!

TinaHeiligers Apr 18, 2022

Uh oh!

nreese Apr 18, 2022

Uh oh!

kibanamachine commented Apr 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

nreese commented Apr 15, 2022

Uh oh!

elasticmachine commented Apr 15, 2022

Uh oh!

nreese commented Apr 15, 2022

Uh oh!

kibana-ci commented Apr 18, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

History

Uh oh!

nickpeihl left a comment

Choose a reason for hiding this comment

Uh oh!

nickpeihl Apr 18, 2022

Choose a reason for hiding this comment

Uh oh!

nickpeihl Apr 18, 2022

Choose a reason for hiding this comment

Uh oh!

TinaHeiligers Apr 18, 2022

Choose a reason for hiding this comment

Uh oh!

nreese Apr 18, 2022

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Apr 18, 2022

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants