Skip to content

[Response Ops] Fix wrong config in comments#130378

Merged
chrisronline merged 2 commits intoelastic:mainfrom
chrisronline:rops/fix_bad_config_in_docs
Apr 18, 2022
Merged

[Response Ops] Fix wrong config in comments#130378
chrisronline merged 2 commits intoelastic:mainfrom
chrisronline:rops/fix_bad_config_in_docs

Conversation

@chrisronline
Copy link
Copy Markdown
Contributor

Resolves #130006

These are the only places I found in the code base so should be a short and sweet review

@chrisronline chrisronline added review release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.3.0 v8.2.1 labels Apr 15, 2022
@chrisronline chrisronline requested a review from a team as a code owner April 15, 2022 14:23
@chrisronline chrisronline self-assigned this Apr 15, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@chrisronline
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @chrisronline

Copy link
Copy Markdown
Contributor

@Zacqary Zacqary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@chrisronline chrisronline merged commit 188c420 into elastic:main Apr 18, 2022
@chrisronline chrisronline deleted the rops/fix_bad_config_in_docs branch April 18, 2022 19:36
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 19, 2022
…disable-server-side

* 'main' of github.com:elastic/kibana: (103 commits)
  [Osquery] Update eslint config (elastic#129637)
  [Uptime] Update monitor saved object mappings (elastic#130433)
  Add links to metricbeat module docs (elastic#130519)
  Add link to troubleshooting guide in confirm data copy (elastic#130420)
  [Step 3] Cleanup charts plugin (elastic#130132)
  [Visualize] Adds a deprecation warning to the pie app (elastic#130447)
  [Maps] fix vector tile load errors not displayed in legend (elastic#130395)
  [CI] Split alerting-api-integration tests into separate cigroups (elastic#130414)
  [CI] Use spot instances for default cigroups in PR CI (elastic#130476)
  [functional-tests] TimePicker optimizations (elastic#130200)
  [kbn/pm] use stable module ids in dist (elastic#130497)
  [8.2.1][Security Solution][Session view] fix full screen session view margin (elastic#130496)
  Fix wrong config in comments (elastic#130378)
  Add deprecated telemetry (elastic#130458)
  Add eslint rule to support breaking up packages (elastic#130483)
  [Security Solution][Endpoint] Fix test stability and un-skip flaky tests (elastic#130176)
  Update object types for SharePoint Online external connector (elastic#130478)
  [Workplace Search] Fix broken feedback link (elastic#130475)
  Rename the term "execution" in config to "run" (elastic#130172)
  [Cloud Posture] use index with keyword mapping (elastic#130456)
  ...

# Conflicts:
#	docs/user/reporting/index.asciidoc
#	x-pack/plugins/reporting/public/types.ts
#	x-pack/plugins/screenshotting/server/screenshots/index.test.ts
#	x-pack/plugins/screenshotting/server/screenshots/index.ts
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 130378 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 20, 2022
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Apr 20, 2022
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 188c420)
chrisronline pushed a commit that referenced this pull request Apr 20, 2022
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 188c420)
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 20, 2022
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes review Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.2.1 v8.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Response Ops] Incorrect config used for triggersActionsUi plugin in various comments/docs

5 participants