Skip to content

[Cloud Posture] use index with keyword mapping#130456

Merged
orouz merged 1 commit intoelastic:mainfrom
orouz:fix_count_query
Apr 18, 2022
Merged

[Cloud Posture] use index with keyword mapping#130456
orouz merged 1 commit intoelastic:mainfrom
orouz:fix_count_query

Conversation

@orouz
Copy link
Copy Markdown
Contributor

@orouz orouz commented Apr 18, 2022

after merging #129639 i noticed the results are odd as the passed / failed don't add up to the total.

this PR adds (back) the index to the default findings query and uses keyword on the count aggregation query, which fixes the issue.

@orouz orouz added release_note:skip Skip the PR/issue when compiling release notes v8.3.0 labels Apr 18, 2022
@orouz orouz requested a review from kfirpeled April 18, 2022 14:30
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 407.1KB 407.1KB +16.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@orouz orouz merged commit a14bcaa into elastic:main Apr 18, 2022
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Apr 18, 2022
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 19, 2022
…disable-server-side

* 'main' of github.com:elastic/kibana: (103 commits)
  [Osquery] Update eslint config (elastic#129637)
  [Uptime] Update monitor saved object mappings (elastic#130433)
  Add links to metricbeat module docs (elastic#130519)
  Add link to troubleshooting guide in confirm data copy (elastic#130420)
  [Step 3] Cleanup charts plugin (elastic#130132)
  [Visualize] Adds a deprecation warning to the pie app (elastic#130447)
  [Maps] fix vector tile load errors not displayed in legend (elastic#130395)
  [CI] Split alerting-api-integration tests into separate cigroups (elastic#130414)
  [CI] Use spot instances for default cigroups in PR CI (elastic#130476)
  [functional-tests] TimePicker optimizations (elastic#130200)
  [kbn/pm] use stable module ids in dist (elastic#130497)
  [8.2.1][Security Solution][Session view] fix full screen session view margin (elastic#130496)
  Fix wrong config in comments (elastic#130378)
  Add deprecated telemetry (elastic#130458)
  Add eslint rule to support breaking up packages (elastic#130483)
  [Security Solution][Endpoint] Fix test stability and un-skip flaky tests (elastic#130176)
  Update object types for SharePoint Online external connector (elastic#130478)
  [Workplace Search] Fix broken feedback link (elastic#130475)
  Rename the term "execution" in config to "run" (elastic#130172)
  [Cloud Posture] use index with keyword mapping (elastic#130456)
  ...

# Conflicts:
#	docs/user/reporting/index.asciidoc
#	x-pack/plugins/reporting/public/types.ts
#	x-pack/plugins/screenshotting/server/screenshots/index.test.ts
#	x-pack/plugins/screenshotting/server/screenshots/index.ts
@orouz orouz added the Team:Cloud Security Cloud Security team related label May 8, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security Posture)

kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants