[Maps] Use content-encoding header from ES for mvt response#130417
Merged
nickpeihl merged 3 commits intoelastic:mainfrom Apr 16, 2022
Merged
[Maps] Use content-encoding header from ES for mvt response#130417nickpeihl merged 3 commits intoelastic:mainfrom
nickpeihl merged 3 commits intoelastic:mainfrom
Conversation
We can't always assume the content-encoding will be gzip. When SSL is enabled in Elasticsearch, the http.compression is disabled by default. We can use the headers from the Elasticsearch response to form the Kibana response. You should have HTTPS enabled to test this PR. Use `yarn es snapshot --ssl` and `yarn start --ssl`.
nickpeihl
added
release_note:fix
Team:Geo
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
nreese
approved these changes
Apr 15, 2022
Contributor
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
Thanks for digging into this one. Such a small change, yet such a huge impact.
Code review, tested in chrome
nickpeihl
added
the
auto-backport
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
nickpeihl
added a commit
to nickpeihl/kibana
that referenced
this pull request
Apr 16, 2022
…130417) * Use content-encoding header from ES for mvt We can't always assume the content-encoding will be gzip. When SSL is enabled in Elasticsearch, the http.compression is disabled by default. We can use the headers from the Elasticsearch response to form the Kibana response. You should have HTTPS enabled to test this PR. Use `yarn es snapshot --ssl` and `yarn start --ssl`. (cherry picked from commit ac5aca4)
nickpeihl
added a commit
to nickpeihl/kibana
that referenced
this pull request
Apr 16, 2022
…130417) * Use content-encoding header from ES for mvt We can't always assume the content-encoding will be gzip. When SSL is enabled in Elasticsearch, the http.compression is disabled by default. We can use the headers from the Elasticsearch response to form the Kibana response. You should have HTTPS enabled to test this PR. Use `yarn es snapshot --ssl` and `yarn start --ssl`. (cherry picked from commit ac5aca4)
nickpeihl
added a commit
that referenced
this pull request
Apr 16, 2022
…#130431) * Use content-encoding header from ES for mvt We can't always assume the content-encoding will be gzip. When SSL is enabled in Elasticsearch, the http.compression is disabled by default. We can use the headers from the Elasticsearch response to form the Kibana response. You should have HTTPS enabled to test this PR. Use `yarn es snapshot --ssl` and `yarn start --ssl`. (cherry picked from commit ac5aca4)
nickpeihl
added a commit
that referenced
this pull request
Apr 16, 2022
…#130432) * Use content-encoding header from ES for mvt We can't always assume the content-encoding will be gzip. When SSL is enabled in Elasticsearch, the http.compression is disabled by default. We can use the headers from the Elasticsearch response to form the Kibana response. You should have HTTPS enabled to test this PR. Use `yarn es snapshot --ssl` and `yarn start --ssl`. (cherry picked from commit ac5aca4)
Contributor
Author
|
Tests for this were added in #130395. |
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
May 24, 2022
…130417) * Use content-encoding header from ES for mvt We can't always assume the content-encoding will be gzip. When SSL is enabled in Elasticsearch, the http.compression is disabled by default. We can use the headers from the Elasticsearch response to form the Kibana response. You should have HTTPS enabled to test this PR. Use `yarn es snapshot --ssl` and `yarn start --ssl`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #130291
Summary
Fixes invalid content-encoding for vector tiles in maps when HTTPS is enabled.
We can't always assume the content-encoding will be gzip. When SSL is enabled in Elasticsearch, the http.compression is disabled by default. We can use the headers from the Elasticsearch response to form the Kibana response.
You should have HTTPS enabled to test this PR. Use
yarn es snapshot --sslandyarn start --ssl.