Skip to content

[Security Solution][Endpoint] Fix test stability and un-skip flaky tests#130176

Merged
paul-tavares merged 5 commits intoelastic:mainfrom
paul-tavares:task/olm-129836-129837-flaky-test-fix
Apr 18, 2022
Merged

[Security Solution][Endpoint] Fix test stability and un-skip flaky tests#130176
paul-tavares merged 5 commits intoelastic:mainfrom
paul-tavares:task/olm-129836-129837-flaky-test-fix

Conversation

@paul-tavares
Copy link
Copy Markdown
Contributor

@paul-tavares paul-tavares commented Apr 13, 2022

Summary

  • Un-skips Jest tests and (hopfully) fixes unstable test runs

fixes #129836
fixes #129837


Ran test locally in a loop 50 times and all passed:

image

@paul-tavares paul-tavares added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution auto-backport Deprecated - use backport:version if exact versions are needed OLM Sprint v8.2.0 v8.3.0 labels Apr 13, 2022
@paul-tavares paul-tavares self-assigned this Apr 13, 2022
@paul-tavares paul-tavares marked this pull request as ready for review April 18, 2022 14:59
@paul-tavares paul-tavares requested a review from a team as a code owner April 18, 2022 14:59
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.8MB 4.8MB +23.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @paul-tavares

@paul-tavares
Copy link
Copy Markdown
Contributor Author

@joeypoon , @parkiino - I'm going to merge this in, but if you get around to it and still have feedback, just post it :)

@paul-tavares paul-tavares merged commit 34dfeeb into elastic:main Apr 18, 2022
@paul-tavares paul-tavares deleted the task/olm-129836-129837-flaky-test-fix branch April 18, 2022 18:30
kibanamachine pushed a commit that referenced this pull request Apr 18, 2022
…sts (#130176)

* artifact list page component: fix url params for pagination not being defined as numbers
* Improvement to tests (maybe)

(cherry picked from commit 34dfeeb)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 18, 2022
…sts (#130176) (#130495)

* artifact list page component: fix url params for pagination not being defined as numbers
* Improvement to tests (maybe)

(cherry picked from commit 34dfeeb)

Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 19, 2022
…disable-server-side

* 'main' of github.com:elastic/kibana: (103 commits)
  [Osquery] Update eslint config (elastic#129637)
  [Uptime] Update monitor saved object mappings (elastic#130433)
  Add links to metricbeat module docs (elastic#130519)
  Add link to troubleshooting guide in confirm data copy (elastic#130420)
  [Step 3] Cleanup charts plugin (elastic#130132)
  [Visualize] Adds a deprecation warning to the pie app (elastic#130447)
  [Maps] fix vector tile load errors not displayed in legend (elastic#130395)
  [CI] Split alerting-api-integration tests into separate cigroups (elastic#130414)
  [CI] Use spot instances for default cigroups in PR CI (elastic#130476)
  [functional-tests] TimePicker optimizations (elastic#130200)
  [kbn/pm] use stable module ids in dist (elastic#130497)
  [8.2.1][Security Solution][Session view] fix full screen session view margin (elastic#130496)
  Fix wrong config in comments (elastic#130378)
  Add deprecated telemetry (elastic#130458)
  Add eslint rule to support breaking up packages (elastic#130483)
  [Security Solution][Endpoint] Fix test stability and un-skip flaky tests (elastic#130176)
  Update object types for SharePoint Online external connector (elastic#130478)
  [Workplace Search] Fix broken feedback link (elastic#130475)
  Rename the term "execution" in config to "run" (elastic#130172)
  [Cloud Posture] use index with keyword mapping (elastic#130456)
  ...

# Conflicts:
#	docs/user/reporting/index.asciidoc
#	x-pack/plugins/reporting/public/types.ts
#	x-pack/plugins/screenshotting/server/screenshots/index.test.ts
#	x-pack/plugins/screenshotting/server/screenshots/index.ts
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
…sts (elastic#130176)

* artifact list page component: fix url params for pagination not being defined as numbers
* Improvement to tests (maybe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed OLM Sprint release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.2.0 v8.3.0

Projects

None yet

5 participants