[Visualize] Adds a deprecation warning to the pie app#130447
Merged
stratoula merged 2 commits intoelastic:mainfrom Apr 19, 2022
Merged
[Visualize] Adds a deprecation warning to the pie app#130447stratoula merged 2 commits intoelastic:mainfrom
stratoula merged 2 commits intoelastic:mainfrom
Conversation
stratoula
added
Feature:Pie Chart
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
stratoula
added
the
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
mbondyra
reviewed
Apr 18, 2022
src/plugins/visualizations/public/visualize_app/components/viz_chart_warning.tsx
Show resolved
Hide resolved
mbondyra
approved these changes
Apr 18, 2022
Contributor
mbondyra
left a comment
mbondyra
left a comment
There was a problem hiding this comment.
tested on FF, works as expected. Code LGTM 👌🏼
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Apr 19, 2022
…disable-server-side * 'main' of github.com:elastic/kibana: (103 commits) [Osquery] Update eslint config (elastic#129637) [Uptime] Update monitor saved object mappings (elastic#130433) Add links to metricbeat module docs (elastic#130519) Add link to troubleshooting guide in confirm data copy (elastic#130420) [Step 3] Cleanup charts plugin (elastic#130132) [Visualize] Adds a deprecation warning to the pie app (elastic#130447) [Maps] fix vector tile load errors not displayed in legend (elastic#130395) [CI] Split alerting-api-integration tests into separate cigroups (elastic#130414) [CI] Use spot instances for default cigroups in PR CI (elastic#130476) [functional-tests] TimePicker optimizations (elastic#130200) [kbn/pm] use stable module ids in dist (elastic#130497) [8.2.1][Security Solution][Session view] fix full screen session view margin (elastic#130496) Fix wrong config in comments (elastic#130378) Add deprecated telemetry (elastic#130458) Add eslint rule to support breaking up packages (elastic#130483) [Security Solution][Endpoint] Fix test stability and un-skip flaky tests (elastic#130176) Update object types for SharePoint Online external connector (elastic#130478) [Workplace Search] Fix broken feedback link (elastic#130475) Rename the term "execution" in config to "run" (elastic#130172) [Cloud Posture] use index with keyword mapping (elastic#130456) ... # Conflicts: # docs/user/reporting/index.asciidoc # x-pack/plugins/reporting/public/types.ts # x-pack/plugins/screenshotting/server/screenshots/index.test.ts # x-pack/plugins/screenshotting/server/screenshots/index.ts
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
May 24, 2022
* [Visualize] Adds a deprecation warning to the pie app * Fix checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #111246
It adds a deprecation message to :
The deprecation message is a bit generic. I dont feel very comfortable on adding 8.4 as the target version as we dont want to remove the old pie implementation if the tooltips work is not finalized. If anybody disagrees with this I have no objections to change it on a specific target version :)
Checklist