[APM] Display throughput as tps (instead of tpm) when bucket size < 60 seconds by sorenlouv · Pull Request #107850 · elastic/kibana

sorenlouv · 2021-08-07T08:31:45Z

This only converts the units from tpm to tps for the throughput chart, when the bucketsize is less than 1 minute. Throughput metrics (stats) in tables are left untouched.

Before

After

sorenlouv · 2021-08-07T11:23:21Z

@elasticmachine merge upstream

kibanamachine · 2021-08-07T11:23:22Z

merge conflict between base and head

elasticmachine · 2021-08-07T11:46:10Z

Pinging @elastic/apm-ui (Team:apm)

.../server/lib/services/get_service_error_groups/get_service_error_group_detailed_statistics.ts

sorenlouv · 2021-08-09T13:03:24Z

jenkins run the e2e

cauemarcondes · 2021-08-09T13:43:38Z

x-pack/plugins/apm/public/components/app/service_overview/service_overview_throughput_chart.tsx

Maybe you could inform the user when we break from tpm to tps?!

Yes, I thought about it but didn't want it to be too confusing. So rather than explaining what both tpm and tps is, it just explains the current state.

WDYT @formgeist ?

Not sure we need to clarify when we switch. I would suggest only to clearly show a different measurement when we switch to seconds. The default measure is minutes, which we can still show in a tooltip next to the title. But we'll change the title and tooltip when we switch, like so;

@formgeist I added the (per second) label

.../server/lib/services/get_service_error_groups/get_service_error_group_detailed_statistics.ts

x-pack/plugins/apm/server/lib/services/get_service_instances/detailed_statistics.ts

x-pack/plugins/apm/server/lib/services/get_throughput.ts

x-pack/plugins/apm/server/lib/transaction_groups/get_error_rate.ts

cauemarcondes · 2021-08-09T14:03:46Z

@sqren It looks like the chart legends are not correct.

# Conflicts: # x-pack/plugins/apm/server/routes/services.ts

sorenlouv · 2021-08-10T09:50:32Z

@cauemarcondes All comments addressed.

sorenlouv · 2021-08-10T12:36:45Z

@elasticmachine merge upstream

cauemarcondes

LGTM

sorenlouv · 2021-08-10T18:26:17Z

@elasticmachine merge upstream

kibanamachine · 2021-08-10T20:47:00Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	4.3MB	4.3MB	+2.5KB

Unknown metric groups

Non-exported public API item count

id	before	after	diff
`apm`	29	30	+1

History

💔 Build #144029 failed 1a3f576
💔 Build #143991 failed e347c8d
💚 Build #143962 succeeded 8f4f227
💚 Build #143888 succeeded 62756796852aa0825990c9a4cad156eca36d11b8
💚 Build #143678 succeeded 2df7a5e0c1f73b9d20394b8c12c690151309bc56

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dominiqueclarke

LGTM

formgeist · 2021-08-11T10:33:54Z

Found a tiny copy bug and reported it here #108171

…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (101 commits) [ML] APM Latency Correlations: Field/value candidates prioritization (elastic#107370) [Reporting] Add lenience to a test on the order of asserted logs (elastic#108135) [Lens] fix do not submit invalid query in filtered metric (elastic#107542) skip flaky test (elastic#108043) fix newly introduced type error (elastic#107593) [Reporting] server side code clean up (elastic#106940) [build_ts_refs] improve caches, allow building a subset of projects (elastic#107981) [APM] Add new ftr_e2e to kibana CI and remove current e2e tests. (elastic#107593) add manage rules link to alerts dropdown (elastic#107950) [ML] Enable Index data visualizer document count chart to update time range query (elastic#106438) [Security Solutions][Detection Engine] Fixes "undefined" crash for author field by adding a migration for it (elastic#107230) [Actions UI] Fixed Jira Api token label. (elastic#107776) [Alerting UI] Fixed display permissions for edit/delete buttons when user has read only access. (elastic#107996) [Maps] fix code owners (elastic#108106) Update EMS landing page url (elastic#108102) Do not render page header for loading domains (elastic#108078) Update dependency @elastic/charts to v33.2.2 (elastic#107939) [APM] Display throughput as tps (instead of tpm) when bucket size < 60 seconds (elastic#107850) [Fleet] Fix all category count (elastic#108089) [Security Solution][Bug] - Disable alert table RBAC until fields sorted (elastic#108034) ... # Conflicts: # x-pack/plugins/reporting/server/export_types/common/generate_png.ts # x-pack/plugins/reporting/server/lib/screenshots/index.ts # x-pack/plugins/reporting/server/lib/screenshots/observable.test.ts # x-pack/plugins/reporting/server/lib/screenshots/observable.ts

…0 seconds (elastic#107850) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…0 seconds (#107850) (#108217) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

sorenlouv force-pushed the convert-tpm-to-tps-for-charts-only branch from ea1a98f to 43fe126 Compare August 7, 2021 11:28

sorenlouv mentioned this pull request Aug 7, 2021

[APM] Fix confusing throughput #104851

Closed

sorenlouv marked this pull request as ready for review August 7, 2021 11:41

sorenlouv requested a review from a team August 7, 2021 11:41

sorenlouv added release_note:fix v7.15.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Aug 7, 2021

botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Aug 7, 2021

sorenlouv commented Aug 7, 2021

View reviewed changes

.../server/lib/services/get_service_error_groups/get_service_error_group_detailed_statistics.ts Outdated Show resolved Hide resolved

sorenlouv changed the title ~~[APM] Convert tpm to tps when throughput < 60~~ [APM] Convert tpm to tps when bucket size is less than 60 Aug 9, 2021

sorenlouv changed the title ~~[APM] Convert tpm to tps when bucket size is less than 60~~ [APM] Convert tpm to tps when bucket size < 60 seconds Aug 9, 2021

sorenlouv changed the title ~~[APM] Convert tpm to tps when bucket size < 60 seconds~~ [APM] Display throughput as tps (instead of tpm) when bucket size < 60 seconds Aug 9, 2021

cauemarcondes reviewed Aug 9, 2021

View reviewed changes

cauemarcondes requested changes Aug 9, 2021

View reviewed changes

sorenlouv requested a review from a team as a code owner August 9, 2021 21:51

sorenlouv added 9 commits August 10, 2021 09:24

[APM] Convert tpm to tps when throughput < 60

e8c8b1b

# Conflicts: # x-pack/plugins/apm/server/routes/services.ts

Fix i18n issues

95303a4

Fix typo firtCurrentPeriod

f3c1843

Fix i18n

3c9ee58

Simplify ternary

ee8646a

Add specs

6edb0f2

Remove _inspect flag

a97f3f6

Address feedback

4219a8b

Disable csm test to fix instability

8f4f227

sorenlouv force-pushed the convert-tpm-to-tps-for-charts-only branch from 6275679 to 8f4f227 Compare August 10, 2021 07:25

Add (per second) to chart title

e347c8d

Merge branch 'master' into convert-tpm-to-tps-for-charts-only

1a3f576

cauemarcondes approved these changes Aug 10, 2021

View reviewed changes

Merge branch 'master' into convert-tpm-to-tps-for-charts-only

69a6c68

dominiqueclarke approved these changes Aug 10, 2021

View reviewed changes

sorenlouv merged commit 1c9edeb into elastic:master Aug 10, 2021

sorenlouv deleted the convert-tpm-to-tps-for-charts-only branch August 10, 2021 21:31

sorenlouv mentioned this pull request Aug 11, 2021

[7.x] [APM] Display throughput as tps (instead of tpm) when bucket size < 60 seconds (#107850) #108217

Merged

cauemarcondes mentioned this pull request Sep 16, 2021

Fix 7.15 release notes #112411

Closed

Conversation

sorenlouv commented Aug 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before

After

Uh oh!

sorenlouv commented Aug 7, 2021

Uh oh!

kibanamachine commented Aug 7, 2021

Uh oh!

elasticmachine commented Aug 7, 2021

Uh oh!

Uh oh!

sorenlouv commented Aug 9, 2021

Uh oh!

cauemarcondes Aug 9, 2021

Choose a reason for hiding this comment

Uh oh!

sorenlouv Aug 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

formgeist Aug 10, 2021

Choose a reason for hiding this comment

Uh oh!

sorenlouv Aug 10, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cauemarcondes commented Aug 9, 2021

Uh oh!

sorenlouv commented Aug 10, 2021

Uh oh!

sorenlouv commented Aug 10, 2021

Uh oh!

cauemarcondes left a comment

Choose a reason for hiding this comment

Uh oh!

sorenlouv commented Aug 10, 2021

Uh oh!

kibanamachine commented Aug 10, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Non-exported public API item count

History

Uh oh!

dominiqueclarke left a comment

Choose a reason for hiding this comment

Uh oh!

formgeist commented Aug 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sorenlouv commented Aug 7, 2021 •

edited

Loading

sorenlouv Aug 9, 2021 •

edited

Loading