[Security Solutions][Detection Engine] Fixes "undefined" crash for author field by adding a migration for it by FrankHassanabad · Pull Request #107230 · elastic/kibana

FrankHassanabad · 2021-07-29T19:14:48Z

Summary

During an earlier upgrade/fix to our system to add defaults to our types, we overlooked the "author" field which wasn't part of the original rules. Users upgrading might get errors such as:

params invalid: Invalid value "undefined" supplied to "author"

This fixes that issue by adding a migration for the author field for 7.14.1.

See #106233 for test instructions or manually remove your author field before upgrading your release and then upgrade and this should be fixed on upgrade.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

x-pack/plugins/alerting/server/saved_objects/migrations.ts

marshallmain

LGTM, thanks for catching and fixing this!

ymao1 · 2021-07-29T19:29:58Z

x-pack/plugins/alerting/server/saved_objects/migrations.test.ts

  });
+
+  describe('7.14.1', () => {
+    test('security solution author field is migrated to array', () => {


maybe a test to make sure existing author fields aren't overridden?

Oh thank you, I will add that.

Added here: f507b65

ymao1 · 2021-07-29T19:30:30Z

x-pack/plugins/alerting/server/saved_objects/migrations.ts

+      ...doc.attributes,
+      params: {
+        ...params,
+        author: params.author != null ? params.author : [],


would it be possible for the author field to be non-null and not an array? just a string maybe?

No, when we introduced it, it was always an array of values as seen here: https://github.com/elastic/kibana/pull/70288/files

…ists

ymao1

LGTM

pmuellr

LGTM

kibanamachine · 2021-08-11T00:19:10Z

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

💚 Build #141807 succeeded f507b65
💚 Build #141763 succeeded 613faea

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @FrankHassanabad

…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (101 commits) [ML] APM Latency Correlations: Field/value candidates prioritization (elastic#107370) [Reporting] Add lenience to a test on the order of asserted logs (elastic#108135) [Lens] fix do not submit invalid query in filtered metric (elastic#107542) skip flaky test (elastic#108043) fix newly introduced type error (elastic#107593) [Reporting] server side code clean up (elastic#106940) [build_ts_refs] improve caches, allow building a subset of projects (elastic#107981) [APM] Add new ftr_e2e to kibana CI and remove current e2e tests. (elastic#107593) add manage rules link to alerts dropdown (elastic#107950) [ML] Enable Index data visualizer document count chart to update time range query (elastic#106438) [Security Solutions][Detection Engine] Fixes "undefined" crash for author field by adding a migration for it (elastic#107230) [Actions UI] Fixed Jira Api token label. (elastic#107776) [Alerting UI] Fixed display permissions for edit/delete buttons when user has read only access. (elastic#107996) [Maps] fix code owners (elastic#108106) Update EMS landing page url (elastic#108102) Do not render page header for loading domains (elastic#108078) Update dependency @elastic/charts to v33.2.2 (elastic#107939) [APM] Display throughput as tps (instead of tpm) when bucket size < 60 seconds (elastic#107850) [Fleet] Fix all category count (elastic#108089) [Security Solution][Bug] - Disable alert table RBAC until fields sorted (elastic#108034) ... # Conflicts: # x-pack/plugins/reporting/server/export_types/common/generate_png.ts # x-pack/plugins/reporting/server/lib/screenshots/index.ts # x-pack/plugins/reporting/server/lib/screenshots/observable.test.ts # x-pack/plugins/reporting/server/lib/screenshots/observable.ts

…thor field by adding a migration for it (elastic#107230) ## Summary Fixes elastic#106233 During an earlier upgrade/fix to our system to add defaults to our types, we overlooked the "author" field which wasn't part of the original rules. Users upgrading might get errors such as: ``` params invalid: Invalid value "undefined" supplied to "author" ``` This fixes that issue by adding a migration for the `author` field for `7.14.1`. See elastic#106233 for test instructions or manually remove your author field before upgrading your release and then upgrade and this should be fixed on upgrade. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

kibanamachine · 2021-08-11T15:14:40Z

💔 Backport failed

Status	Branch	Result
✅	7.x
❌	7.14	Commit could not be cherrypicked due to conflicts

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 107230

…thor field by adding a migration for it (elastic#107230) ## Summary Fixes elastic#106233 During an earlier upgrade/fix to our system to add defaults to our types, we overlooked the "author" field which wasn't part of the original rules. Users upgrading might get errors such as: ``` params invalid: Invalid value "undefined" supplied to "author" ``` This fixes that issue by adding a migration for the `author` field for `7.14.1`. See elastic#106233 for test instructions or manually remove your author field before upgrading your release and then upgrade and this should be fixed on upgrade. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

…thor field by adding a migration for it (elastic#107230) ## Summary Fixes elastic#106233 During an earlier upgrade/fix to our system to add defaults to our types, we overlooked the "author" field which wasn't part of the original rules. Users upgrading might get errors such as: ``` params invalid: Invalid value "undefined" supplied to "author" ``` This fixes that issue by adding a migration for the `author` field for `7.14.1`. See elastic#106233 for test instructions or manually remove your author field before upgrading your release and then upgrade and this should be fixed on upgrade. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios # Conflicts: # x-pack/plugins/alerting/server/saved_objects/migrations.test.ts

…thor field by adding a migration for it (#107230) (#108218) ## Summary Fixes #106233 During an earlier upgrade/fix to our system to add defaults to our types, we overlooked the "author" field which wasn't part of the original rules. Users upgrading might get errors such as: ``` params invalid: Invalid value "undefined" supplied to "author" ``` This fixes that issue by adding a migration for the `author` field for `7.14.1`. See #106233 for test instructions or manually remove your author field before upgrading your release and then upgrade and this should be fixed on upgrade. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: Frank Hassanabad <frank.hassanabad@elastic.co>

… for author field by adding a migration for it (#107230) (#108221) * [Security Solutions][Detection Engine] Fixes "undefined" crash for author field by adding a migration for it (#107230) ## Summary Fixes #106233 During an earlier upgrade/fix to our system to add defaults to our types, we overlooked the "author" field which wasn't part of the original rules. Users upgrading might get errors such as: ``` params invalid: Invalid value "undefined" supplied to "author" ``` This fixes that issue by adding a migration for the `author` field for `7.14.1`. See #106233 for test instructions or manually remove your author field before upgrading your release and then upgrade and this should be fixed on upgrade. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios # Conflicts: # x-pack/plugins/alerting/server/saved_objects/migrations.test.ts * Fixed merge mistakes as the two test versions are very different * Fixes another area where the backport system is very different

Fixes author field

50badbe

FrankHassanabad requested review from marshallmain and peluja1012 July 29, 2021 19:17

FrankHassanabad self-assigned this Jul 29, 2021

FrankHassanabad added v8.0.0 v7.15.0 v7.14.1 Feature:Detection Rules Security Solution rules and Detection Engine impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. release_note:fix labels Jul 29, 2021

FrankHassanabad marked this pull request as ready for review July 29, 2021 19:19

FrankHassanabad requested a review from a team as a code owner July 29, 2021 19:19

mikecote reviewed Jul 29, 2021

View reviewed changes

x-pack/plugins/alerting/server/saved_objects/migrations.ts Outdated Show resolved Hide resolved

FrankHassanabad added 2 commits July 29, 2021 13:21

Fixes the author field for 7.14.1 instead of 7.14.0

1c60b30

Updated migration to be 7.14.1 with naming conventions

613faea

marshallmain approved these changes Jul 29, 2021

View reviewed changes

ymao1 reviewed Jul 29, 2021

View reviewed changes

FrankHassanabad added 2 commits July 29, 2021 13:39

Merge branch 'master' into add-so-migration

8910925

Adds a test to make sure we do not override something that already ex…

f507b65

…ists

ymao1 approved these changes Aug 2, 2021

View reviewed changes

pmuellr approved these changes Aug 2, 2021

View reviewed changes

Merge branch 'master' into add-so-migration

fe361a6

FrankHassanabad enabled auto-merge (squash) August 10, 2021 22:00

FrankHassanabad merged commit 978c44e into elastic:master Aug 11, 2021

FrankHassanabad added auto-backport Deprecated - use backport:version if exact versions are needed and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Aug 11, 2021

kibanamachine mentioned this pull request Aug 11, 2021

[7.x] [Security Solutions][Detection Engine] Fixes "undefined" crash for author field by adding a migration for it (#107230) #108218

Merged

FrankHassanabad mentioned this pull request Aug 11, 2021

[7.x] [Security Solutions][Detection Engine] Fixes "undefined" crash for author field by adding a migration for it (#107230) #108219

Closed

FrankHassanabad mentioned this pull request Aug 11, 2021

[7.14] [Security Solutions][Detection Engine] Fixes "undefined" crash for author field by adding a migration for it (#107230) #108221

Merged

peluja1012 mentioned this pull request Aug 11, 2021

[Security Solution]An error "Rule failure" is getting displayed on Rule detail page. #106233

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solutions][Detection Engine] Fixes "undefined" crash for author field by adding a migration for it#107230

[Security Solutions][Detection Engine] Fixes "undefined" crash for author field by adding a migration for it#107230
FrankHassanabad merged 6 commits intoelastic:masterfrom
FrankHassanabad:add-so-migration

FrankHassanabad commented Jul 29, 2021 •

edited

Loading

Uh oh!

Uh oh!

marshallmain left a comment

Uh oh!

ymao1 Jul 29, 2021

Uh oh!

FrankHassanabad Jul 29, 2021

Uh oh!

FrankHassanabad Jul 29, 2021

Uh oh!

ymao1 Jul 29, 2021

Uh oh!

FrankHassanabad Jul 29, 2021

Uh oh!

ymao1 left a comment

Uh oh!

pmuellr left a comment

Uh oh!

kibanamachine commented Aug 11, 2021

Uh oh!

kibanamachine commented Aug 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

FrankHassanabad commented Jul 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

Uh oh!

marshallmain left a comment

Choose a reason for hiding this comment

Uh oh!

ymao1 Jul 29, 2021

Choose a reason for hiding this comment

Uh oh!

FrankHassanabad Jul 29, 2021

Choose a reason for hiding this comment

Uh oh!

FrankHassanabad Jul 29, 2021

Choose a reason for hiding this comment

Uh oh!

ymao1 Jul 29, 2021

Choose a reason for hiding this comment

Uh oh!

FrankHassanabad Jul 29, 2021

Choose a reason for hiding this comment

Uh oh!

ymao1 left a comment

Choose a reason for hiding this comment

Uh oh!

pmuellr left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Aug 11, 2021

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

kibanamachine commented Aug 11, 2021

💔 Backport failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

FrankHassanabad commented Jul 29, 2021 •

edited

Loading