Skip to content

[Actions UI] Fixed Jira Api token label.#107776

Merged
YulNaumenko merged 7 commits intoelastic:masterfrom
YulNaumenko:actions-jira-ui-title-api-key
Aug 11, 2021
Merged

[Actions UI] Fixed Jira Api token label.#107776
YulNaumenko merged 7 commits intoelastic:masterfrom
YulNaumenko:actions-jira-ui-title-api-key

Conversation

@YulNaumenko
Copy link
Copy Markdown
Contributor

@YulNaumenko YulNaumenko commented Aug 5, 2021

Summary

Resolves #104783

In the current PR changed the label for Jira action connector due to the upcoming drop support for password based Basic Authentication (API is a recommended way due to the API docs):
API token or password -> API token
Username or email address -> Email address

Screen Shot 2021-08-09 at 3 02 05 PM

due to the integration we are supporting

@YulNaumenko YulNaumenko self-assigned this Aug 5, 2021
@YulNaumenko YulNaumenko added Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.15.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Aug 5, 2021
@YulNaumenko YulNaumenko marked this pull request as ready for review August 5, 2021 17:40
@YulNaumenko YulNaumenko requested a review from a team as a code owner August 5, 2021 17:40
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

Copy link
Copy Markdown
Contributor

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to fix the doc as well ...

image

@YulNaumenko YulNaumenko requested a review from pmuellr August 9, 2021 20:51
Copy link
Copy Markdown
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YulNaumenko
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@YulNaumenko
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@YulNaumenko
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.6MB -144.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @YulNaumenko

@YulNaumenko YulNaumenko merged commit 538a6d9 into elastic:master Aug 11, 2021
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Aug 11, 2021
* [Actions UI] Fixed Jira Api token label.

* fixed tests

* fixed username

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
YulNaumenko added a commit that referenced this pull request Aug 11, 2021
* [Actions UI] Fixed Jira Api token label.

* fixed tests

* fixed username

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 11, 2021
…-png-pdf-report-type

* 'master' of github.com:elastic/kibana: (101 commits)
  [ML] APM Latency Correlations: Field/value candidates prioritization (elastic#107370)
  [Reporting] Add lenience to a test on the order of asserted logs (elastic#108135)
  [Lens] fix do not submit invalid query in filtered metric (elastic#107542)
  skip flaky test (elastic#108043)
  fix newly introduced type error (elastic#107593)
  [Reporting] server side code clean up (elastic#106940)
  [build_ts_refs] improve caches, allow building a subset of projects (elastic#107981)
  [APM] Add new ftr_e2e to kibana CI and remove current e2e tests. (elastic#107593)
  add manage rules link to alerts dropdown (elastic#107950)
  [ML] Enable Index data visualizer document count chart to update time range query (elastic#106438)
  [Security Solutions][Detection Engine] Fixes "undefined" crash for author field by adding a migration for it (elastic#107230)
  [Actions UI] Fixed Jira Api token label. (elastic#107776)
  [Alerting UI] Fixed display permissions for edit/delete buttons when user has read only access. (elastic#107996)
  [Maps] fix code owners (elastic#108106)
  Update EMS landing page url (elastic#108102)
  Do not render page header for loading domains (elastic#108078)
  Update dependency @elastic/charts to v33.2.2 (elastic#107939)
  [APM] Display throughput as tps (instead of tpm) when bucket size < 60 seconds (elastic#107850)
  [Fleet] Fix all category count (elastic#108089)
  [Security Solution][Bug] - Disable alert table RBAC until fields sorted (elastic#108034)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/export_types/common/generate_png.ts
#	x-pack/plugins/reporting/server/lib/screenshots/index.ts
#	x-pack/plugins/reporting/server/lib/screenshots/observable.test.ts
#	x-pack/plugins/reporting/server/lib/screenshots/observable.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.15.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Alerting] Jira connector should only list API token

5 participants