Skip to content

[Fleet] Fix all category count#108089

Merged
nchaulet merged 2 commits intoelastic:masterfrom
nchaulet:fix-107405-category-count
Aug 10, 2021
Merged

[Fleet] Fix all category count#108089
nchaulet merged 2 commits intoelastic:masterfrom
nchaulet:fix-107405-category-count

Conversation

@nchaulet
Copy link
Copy Markdown
Member

Summary

Resolve #107405
In #107652 I introduced a new bug in the category count.
When we select a category the all category count is wrong that PR fix that.

Before

Screen Shot 2021-08-10 at 2 36 31 PM

After

Screen Shot 2021-08-10 at 2 43 11 PM

@nchaulet nchaulet added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.14.1 labels Aug 10, 2021
@nchaulet nchaulet requested a review from kpollich August 10, 2021 18:47
@nchaulet nchaulet requested a review from a team as a code owner August 10, 2021 18:47
@nchaulet nchaulet self-assigned this Aug 10, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet
Copy link
Copy Markdown
Member Author

@elasticmachine merge upstream

Copy link
Copy Markdown
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nchaulet nchaulet enabled auto-merge (squash) August 10, 2021 19:26
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 716.8KB 717.2KB +390.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit 422f64c into elastic:master Aug 10, 2021
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 11, 2021
…-png-pdf-report-type

* 'master' of github.com:elastic/kibana: (101 commits)
  [ML] APM Latency Correlations: Field/value candidates prioritization (elastic#107370)
  [Reporting] Add lenience to a test on the order of asserted logs (elastic#108135)
  [Lens] fix do not submit invalid query in filtered metric (elastic#107542)
  skip flaky test (elastic#108043)
  fix newly introduced type error (elastic#107593)
  [Reporting] server side code clean up (elastic#106940)
  [build_ts_refs] improve caches, allow building a subset of projects (elastic#107981)
  [APM] Add new ftr_e2e to kibana CI and remove current e2e tests. (elastic#107593)
  add manage rules link to alerts dropdown (elastic#107950)
  [ML] Enable Index data visualizer document count chart to update time range query (elastic#106438)
  [Security Solutions][Detection Engine] Fixes "undefined" crash for author field by adding a migration for it (elastic#107230)
  [Actions UI] Fixed Jira Api token label. (elastic#107776)
  [Alerting UI] Fixed display permissions for edit/delete buttons when user has read only access. (elastic#107996)
  [Maps] fix code owners (elastic#108106)
  Update EMS landing page url (elastic#108102)
  Do not render page header for loading domains (elastic#108078)
  Update dependency @elastic/charts to v33.2.2 (elastic#107939)
  [APM] Display throughput as tps (instead of tpm) when bucket size < 60 seconds (elastic#107850)
  [Fleet] Fix all category count (elastic#108089)
  [Security Solution][Bug] - Disable alert table RBAC until fields sorted (elastic#108034)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/export_types/common/generate_png.ts
#	x-pack/plugins/reporting/server/lib/screenshots/index.ts
#	x-pack/plugins/reporting/server/lib/screenshots/observable.test.ts
#	x-pack/plugins/reporting/server/lib/screenshots/observable.ts
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 108089 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 12, 2021
@jen-huang jen-huang added auto-backport Deprecated - use backport:version if exact versions are needed and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Aug 12, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 12, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 12, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Backport successful

Status Branch Result
7.x
7.14

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 13, 2021
Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 13, 2021
kibanamachine added a commit that referenced this pull request Aug 13, 2021
Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
@dikshachauhan-qasource
Copy link
Copy Markdown

Hi @nchaulet

We have regressed this issue and found it working fine now on 8.0.0 snapshot build.

Build details:
BUILD 45390
COMMIT b1f38f4

Observation:

  • Total integrations Count remains same even on navigating to other sub integration categories.

Screenshot:
image

Thanks
QAS

@nchaulet nchaulet deleted the fix-107405-category-count branch August 19, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.14.1 v7.15.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Integrations] Incorrect number of integrations

6 participants