[App Search] Crawler: do not render page header while loading domains#108078
Merged
cee-chen merged 2 commits intoelastic:masterfrom Aug 10, 2021
Merged
[App Search] Crawler: do not render page header while loading domains#108078cee-chen merged 2 commits intoelastic:masterfrom
cee-chen merged 2 commits intoelastic:masterfrom
Conversation
cee-chen
added
release_note:skip
cee-chen
commented
Aug 10, 2021
| pageTitle: displayDomainUrl, | ||
| rightSideItems: [<ManageCrawlsPopover />, <CrawlerStatusIndicator />], | ||
| }} | ||
| pageChrome={getEngineBreadcrumbs([CRAWLER_TITLE, domain?.url || '...'])} |
Contributor
Author
There was a problem hiding this comment.
This is a pattern used by Workplace Search as well, FWIW
Comment on lines
+43
to
+44
| dataLoading | ||
| ? undefined |
Contributor
Author
There was a problem hiding this comment.
Also a pattern used in our codebase - I think more in WS than AS, since AS has more names that can be derived from the URL vs IDs
byronhulcher
approved these changes
Aug 10, 2021
Contributor
byronhulcher
left a comment
byronhulcher
left a comment
There was a problem hiding this comment.
Thanks for improving this @constancecchen!
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Contributor
Author
|
looking nervously at auto-backport bot |
tylersmalley
added
auto-backport
Contributor
Author
|
Looks like there's a GH actions outage (thanks Tyler!), I'll just manually backport |
cee-chen
removed
the
auto-backport
Contributor
💔 Backport failed
To backport manually run: |
cee-chen
added
the
auto-backport
Contributor
Author
|
Trying again since #107953 merged |
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 10, 2021
kibanamachine
added a commit
that referenced
this pull request
Aug 11, 2021
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 11, 2021
…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (101 commits) [ML] APM Latency Correlations: Field/value candidates prioritization (elastic#107370) [Reporting] Add lenience to a test on the order of asserted logs (elastic#108135) [Lens] fix do not submit invalid query in filtered metric (elastic#107542) skip flaky test (elastic#108043) fix newly introduced type error (elastic#107593) [Reporting] server side code clean up (elastic#106940) [build_ts_refs] improve caches, allow building a subset of projects (elastic#107981) [APM] Add new ftr_e2e to kibana CI and remove current e2e tests. (elastic#107593) add manage rules link to alerts dropdown (elastic#107950) [ML] Enable Index data visualizer document count chart to update time range query (elastic#106438) [Security Solutions][Detection Engine] Fixes "undefined" crash for author field by adding a migration for it (elastic#107230) [Actions UI] Fixed Jira Api token label. (elastic#107776) [Alerting UI] Fixed display permissions for edit/delete buttons when user has read only access. (elastic#107996) [Maps] fix code owners (elastic#108106) Update EMS landing page url (elastic#108102) Do not render page header for loading domains (elastic#108078) Update dependency @elastic/charts to v33.2.2 (elastic#107939) [APM] Display throughput as tps (instead of tpm) when bucket size < 60 seconds (elastic#107850) [Fleet] Fix all category count (elastic#108089) [Security Solution][Bug] - Disable alert table RBAC until fields sorted (elastic#108034) ... # Conflicts: # x-pack/plugins/reporting/server/export_types/common/generate_png.ts # x-pack/plugins/reporting/server/lib/screenshots/index.ts # x-pack/plugins/reporting/server/lib/screenshots/observable.test.ts # x-pack/plugins/reporting/server/lib/screenshots/observable.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@byronhulcher (cc @daveyholler) UX suggestion I noticed while QAing crawler engines locally. The "Loading..." title threw me off a bit, and it felt a little heavier/more distracting than just a simple logo loading icon.
This is a totally optional suggestion, so feel free to let me know if you don't prefer it and I can just close this PR; I just thought this would be quicker/easier to open in a PR than to try and describe in Slack.
Before
After
Checklist