[Test] Randomly disable sequence numbers in CcrTimeSeriesDataStreamsIT#143930
Conversation
tlrx
added
>test
|
Pinging @elastic/es-distributed (Team:Distributed) |
| ) | ||
| ); | ||
| } | ||
| // Sequence numbers cannot be trimmed for points, so we enforce doc values only usage |
There was a problem hiding this comment.
Do we want to remove this comment?
There was a problem hiding this comment.
No, I think it is still valid, we can't trim seq no if SEQ_NO_INDEX_OPTIONS_SETTING uses points. But the early exit here means that if a template set SEQ_NO_INDEX_OPTIONS_SETTING it is ignored until the index creation time :(
We could change the SEQ_NO_INDEX_OPTIONS_SETTING to also uses IndexVersion.ZERO but I'm a bit worried about potential impacts :(
There was a problem hiding this comment.
Yep, Kostas hit the same issue I think #143897 (comment)
There was a problem hiding this comment.
Thanks for pointing this, I'll wait for Kostas pull request to be merged then.
There was a problem hiding this comment.
I think we want to reinstate the comment here?
There was a problem hiding this comment.
I think I misread Francisco's initial comment, yes the comment should be reinstated and should not have been removed in my PR.
I pushed bc1b102
| if (IndexSettings.TSDB_SYNTHETIC_ID_FEATURE_FLAG) { | ||
| settingsBuilder.put(IndexSettings.SYNTHETIC_ID.getKey(), useSyntheticId); | ||
| } | ||
| if (IndexSettings.DISABLE_SEQUENCE_NUMBERS_FEATURE_FLAG && randomBoolean()) { |
There was a problem hiding this comment.
Does this need to be combined with the doc_values_only flag as well, or is that always set here?
There was a problem hiding this comment.
Time-series indices default to doc values only in recent versions so it is OK
romseygeek
left a comment
romseygeek
left a comment
There was a problem hiding this comment.
One nit, LGTM otherwise.
| ) | ||
| ); | ||
| } | ||
| // Sequence numbers cannot be trimmed for points, so we enforce doc values only usage |
There was a problem hiding this comment.
I think we want to reinstate the comment here?
|
#144180 has been merged so I can resume merging this change. |
tlrx
added
the
auto-merge-without-approval
|
Tests are green, merging |
tlrx
deleted the
2026/03/10-disable-seq-no-in-ccrtimeseriesdatastreamsit
branch
…elocations * upstream/main: (72 commits) [Test] Randomly disable sequence numbers in CcrTimeSeriesDataStreamsIT (elastic#143930) Fix AsyncSearchIndexServiceTests.testCircuitBreaker failure (elastic#144058) Refine GenerativeIT some more, this time with accounting for some added (elastic#144220) ESQL: Physical Planning on the Lookup Node (elastic#143707) Mute org.elasticsearch.xpack.esql.CsvIT test {csv-spec:approximation.Approximate stats by with zero variance} elastic#144240 Trigger counter metrics in test for delta temporality measurements (elastic#144193) fix capabiltiy approximation_v3 (elastic#144230) [ci] Add PR pipeline for testing ipv6 and fix tests not working with ipv6 (elastic#140473) update (elastic#144095) Make from/to optional in TBUCKET when Kibana timestamp filter is present (elastic#144057) Extract reroute behavior from create-index request classes (elastic#144140) ESQL: Fix release build only failures (elastic#144122) ES|QL query approximation: move sample correction to data node (elastic#144005) Add indexing pressure tracking to OTLP endpoints (elastic#144009) Fix replica writes after _seq_no doc values are pruned (elastic#144180) allow tests to configure supportsLoadingConfig (elastic#144061) [ES|QL] Unmute testGiantTextFieldInSubqueryIntermediateResultsWithSort (elastic#144126) [ESQL][DOCS] Add CPS page (unpublished for moment) (elastic#144206) ESQL: Forbid "load" unmapped_fields for certain commands (elastic#144115) Add CCS Remote Views Detection (elastic#143384) ...
elastic#143930) This change randomly disables sequence numbers in CcrTimeSeriesDataStreamsIT so that it runs with synthetic id too. Note: We don't do extensive checks to avoid CcrTimeSeriesDataStreamsIT do too many checks at a time. I'll follow up with a dedicated CCR integration test for disabled sequence numbers on regular indices where we'll check that seq no are pruned away from segments. Relates elastic#136305
elastic#143930) This change randomly disables sequence numbers in CcrTimeSeriesDataStreamsIT so that it runs with synthetic id too. Note: We don't do extensive checks to avoid CcrTimeSeriesDataStreamsIT do too many checks at a time. I'll follow up with a dedicated CCR integration test for disabled sequence numbers on regular indices where we'll check that seq no are pruned away from segments. Relates elastic#136305
4 participants
This change randomly disables sequence numbers in CcrTimeSeriesDataStreamsIT so that it runs with synthetic id too.
Note: We don't do extensive checks to avoid CcrTimeSeriesDataStreamsIT do too many checks at a time. I'll follow up with a dedicated CCR integration test for disabled sequence numbers on regular indices where we'll check that seq no are pruned away from segments.
Relates #136305