Skip to content

allow tests to configure supportsLoadingConfig#144061

Merged
not-napoleon merged 3 commits intoelastic:mainfrom
not-napoleon:set-supportBlockLoaderConfig-on-TestSearchStats
Mar 13, 2026
Merged

allow tests to configure supportsLoadingConfig#144061
not-napoleon merged 3 commits intoelastic:mainfrom
not-napoleon:set-supportBlockLoaderConfig-on-TestSearchStats

Conversation

@not-napoleon
Copy link
Copy Markdown
Member

Allow tests to configure the availability of BlockLoaderEvaluator optimizations by overriding the supportsLoaderConfig method. Previously, that method would always return true in tests, making it challenging to test both the optimized and non-optimized paths.

@not-napoleon not-napoleon added >test Issues or PRs that are addressing/adding tests :StorageEngine/ES|QL Timeseries / metrics / PromQL / logsdb capabilities in ES|QL v9.4.0 labels Mar 11, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@not-napoleon not-napoleon merged commit 5ce0940 into elastic:main Mar 13, 2026
36 checks passed
szybia added a commit to szybia/elasticsearch that referenced this pull request Mar 13, 2026
…elocations

* upstream/main: (72 commits)
  [Test] Randomly disable sequence numbers in CcrTimeSeriesDataStreamsIT (elastic#143930)
  Fix AsyncSearchIndexServiceTests.testCircuitBreaker failure (elastic#144058)
  Refine GenerativeIT some more, this time with accounting for some added (elastic#144220)
  ESQL: Physical Planning on the Lookup Node (elastic#143707)
  Mute org.elasticsearch.xpack.esql.CsvIT test {csv-spec:approximation.Approximate stats by with zero variance} elastic#144240
  Trigger counter metrics in test for delta temporality measurements (elastic#144193)
  fix capabiltiy approximation_v3 (elastic#144230)
  [ci] Add PR pipeline for testing ipv6 and fix tests not working with ipv6 (elastic#140473)
  update (elastic#144095)
  Make from/to optional in TBUCKET when Kibana timestamp filter is present (elastic#144057)
  Extract reroute behavior from create-index request classes (elastic#144140)
  ESQL: Fix release build only failures (elastic#144122)
  ES|QL query approximation: move sample correction to data node (elastic#144005)
  Add indexing pressure tracking to OTLP endpoints (elastic#144009)
  Fix replica writes after _seq_no doc values are pruned (elastic#144180)
  allow tests to configure supportsLoadingConfig (elastic#144061)
  [ES|QL] Unmute testGiantTextFieldInSubqueryIntermediateResultsWithSort (elastic#144126)
  [ESQL][DOCS] Add CPS page (unpublished for moment) (elastic#144206)
  ESQL: Forbid "load" unmapped_fields for certain commands (elastic#144115)
  Add CCS Remote Views Detection (elastic#143384)
  ...
michalborek pushed a commit to michalborek/elasticsearch that referenced this pull request Mar 23, 2026
Allow tests to configure the availability of BlockLoaderEvaluator optimizations by overriding the supportsLoaderConfig method. Previously, that method would always return true in tests, making it challenging to test both the optimized and non-optimized paths.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:StorageEngine/ES|QL Timeseries / metrics / PromQL / logsdb capabilities in ES|QL Team:StorageEngine >test Issues or PRs that are addressing/adding tests v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants