ESQL: Fix release build only failures#144122
Merged
julian-elastic merged 5 commits intoelastic:mainfrom Mar 13, 2026
Merged
Conversation
julian-elastic
added
:Analytics/ES|QL
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Contributor
Author
|
@GalLalouche I have confirmed the change in testLengthPushedWithTopN is due to your PR here #142834, can you please code review and see if the change is expected? |
cimequinox
reviewed
Mar 12, 2026
...rc/javaRestTest/java/org/elasticsearch/xpack/esql/qa/single_node/PushExpressionToLoadIT.java
Outdated
Show resolved
Hide resolved
Contributor
|
@julian-elastic Could you please explain in the PR exactly what is this PR doing? I get that it's trying to fix a broken test, but why was it broken and how this fix it? It would make it a lot easier to review :) |
GalLalouche
reviewed
Mar 12, 2026
...rc/javaRestTest/java/org/elasticsearch/xpack/esql/qa/single_node/PushExpressionToLoadIT.java
Outdated
Show resolved
Hide resolved
cimequinox
approved these changes
Mar 12, 2026
Contributor
cimequinox
left a comment
cimequinox
left a comment
There was a problem hiding this comment.
The changes address the issue reported in #144086
- PushExpressionToLoadIT (3 tests) — @julian-elasticTests assert StreamingLookupOperator in execution plan profiles but LocalExecutionPlanner.shouldUseStreamingOperator() returns false when isSnapshot() == false, falling back to LookupOperator.
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Mar 13, 2026
…elocations * upstream/main: (72 commits) [Test] Randomly disable sequence numbers in CcrTimeSeriesDataStreamsIT (elastic#143930) Fix AsyncSearchIndexServiceTests.testCircuitBreaker failure (elastic#144058) Refine GenerativeIT some more, this time with accounting for some added (elastic#144220) ESQL: Physical Planning on the Lookup Node (elastic#143707) Mute org.elasticsearch.xpack.esql.CsvIT test {csv-spec:approximation.Approximate stats by with zero variance} elastic#144240 Trigger counter metrics in test for delta temporality measurements (elastic#144193) fix capabiltiy approximation_v3 (elastic#144230) [ci] Add PR pipeline for testing ipv6 and fix tests not working with ipv6 (elastic#140473) update (elastic#144095) Make from/to optional in TBUCKET when Kibana timestamp filter is present (elastic#144057) Extract reroute behavior from create-index request classes (elastic#144140) ESQL: Fix release build only failures (elastic#144122) ES|QL query approximation: move sample correction to data node (elastic#144005) Add indexing pressure tracking to OTLP endpoints (elastic#144009) Fix replica writes after _seq_no doc values are pruned (elastic#144180) allow tests to configure supportsLoadingConfig (elastic#144061) [ES|QL] Unmute testGiantTextFieldInSubqueryIntermediateResultsWithSort (elastic#144126) [ESQL][DOCS] Add CPS page (unpublished for moment) (elastic#144206) ESQL: Forbid "load" unmapped_fields for certain commands (elastic#144115) Add CCS Remote Views Detection (elastic#143384) ...
ncordon
pushed a commit
to ncordon/elasticsearch
that referenced
this pull request
Mar 16, 2026
* Fix release build failures * Address code review comments Assisted by Cursor
michalborek
pushed a commit
to michalborek/elasticsearch
that referenced
this pull request
Mar 23, 2026
* Fix release build failures * Address code review comments Assisted by Cursor
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a few broken tests that generate slightly different plan in Release vs Snapshot build and would fail in release build.
testLengthPushedWithTopN () - previously different result was expected in Release vs Snapshot. With ESQL: Remove snapshot protection from node reduce late materialization #142834 late materialization is enabled in Release too, so now the plan is the same.
For testLengthNotPushedToLookupJoinKeyword() and testLengthNotPushedToLookupJoinKeywordSameName() - the operator used is different in Release vs Snapshot, as StreamingLookup is behind Snapshot flag for now. Changed the tests to expect StreamingLookupFromIndexOperator in Snapshot and LookupFromIndexOperator in Release.
Partially addresses: #144086