Skip to content

Trigger counter metrics in test for delta temporality measurements#144193

Merged
mamazzol merged 2 commits intoelastic:mainfrom
mamazzol:ci-144072
Mar 13, 2026
Merged

Trigger counter metrics in test for delta temporality measurements#144193
mamazzol merged 2 commits intoelastic:mainfrom
mamazzol:ci-144072

Conversation

@mamazzol
Copy link
Copy Markdown
Contributor

A couple of quality of life changes to make sure this test passes reliably:

  • Avoid potential ClassCastExceptions
  • Catching Exceptions in RecordingApmServer
  • Increment counter so it produces deltas >=0 for the test to be successful.

Closes: #144072

@mamazzol mamazzol requested a review from a team March 13, 2026 12:59
@mamazzol mamazzol added the >test Issues or PRs that are addressing/adding tests label Mar 13, 2026
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.4.0 labels Mar 13, 2026
@mamazzol mamazzol added Team:Core/Infra Meta label for core/infra team :Core/Infra/Metrics Metrics and metering infrastructure and removed needs:triage Requires assignment of a team area label v9.4.0 labels Mar 13, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@JVerwolf JVerwolf self-requested a review March 13, 2026 15:51
Copy link
Copy Markdown
Contributor

@JVerwolf JVerwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This fixes the root cause and several secondary failure modes. Nice work!

@mamazzol mamazzol merged commit da3f83c into elastic:main Mar 13, 2026
36 checks passed
@mamazzol mamazzol deleted the ci-144072 branch March 13, 2026 16:36
szybia added a commit to szybia/elasticsearch that referenced this pull request Mar 13, 2026
…elocations

* upstream/main: (72 commits)
  [Test] Randomly disable sequence numbers in CcrTimeSeriesDataStreamsIT (elastic#143930)
  Fix AsyncSearchIndexServiceTests.testCircuitBreaker failure (elastic#144058)
  Refine GenerativeIT some more, this time with accounting for some added (elastic#144220)
  ESQL: Physical Planning on the Lookup Node (elastic#143707)
  Mute org.elasticsearch.xpack.esql.CsvIT test {csv-spec:approximation.Approximate stats by with zero variance} elastic#144240
  Trigger counter metrics in test for delta temporality measurements (elastic#144193)
  fix capabiltiy approximation_v3 (elastic#144230)
  [ci] Add PR pipeline for testing ipv6 and fix tests not working with ipv6 (elastic#140473)
  update (elastic#144095)
  Make from/to optional in TBUCKET when Kibana timestamp filter is present (elastic#144057)
  Extract reroute behavior from create-index request classes (elastic#144140)
  ESQL: Fix release build only failures (elastic#144122)
  ES|QL query approximation: move sample correction to data node (elastic#144005)
  Add indexing pressure tracking to OTLP endpoints (elastic#144009)
  Fix replica writes after _seq_no doc values are pruned (elastic#144180)
  allow tests to configure supportsLoadingConfig (elastic#144061)
  [ES|QL] Unmute testGiantTextFieldInSubqueryIntermediateResultsWithSort (elastic#144126)
  [ESQL][DOCS] Add CPS page (unpublished for moment) (elastic#144206)
  ESQL: Forbid "load" unmapped_fields for certain commands (elastic#144115)
  Add CCS Remote Views Detection (elastic#143384)
  ...
ncordon pushed a commit to ncordon/elasticsearch that referenced this pull request Mar 16, 2026
michalborek pushed a commit to michalborek/elasticsearch that referenced this pull request Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Metrics Metrics and metering infrastructure Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] MetricsApmIT testApmIntegration {withOTel=true} failing

3 participants