[TEST] Add coverage for disabling sequence numbers in TSDB ITs#143897
Merged
kkrik-es merged 19 commits intoelastic:mainfrom Mar 11, 2026
Merged
[TEST] Add coverage for disabling sequence numbers in TSDB ITs#143897kkrik-es merged 19 commits intoelastic:mainfrom
kkrik-es merged 19 commits intoelastic:mainfrom
Conversation
kkrik-es
added
>test
kkrik-es
changed the title
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
kkrik-es
commented
Mar 10, 2026
| if ((indexMode == IndexMode.LOGSDB || indexMode == IndexMode.TIME_SERIES) | ||
| && IndexMetadata.SETTING_INDEX_VERSION_CREATED.get(settings).onOrAfter(IndexVersions.SEQ_NO_WITHOUT_POINTS)) { | ||
| && (IndexMetadata.SETTING_INDEX_VERSION_CREATED.get(settings).onOrAfter(IndexVersions.SEQ_NO_WITHOUT_POINTS) | ||
| || IndexMetadata.SETTING_INDEX_VERSION_CREATED.get(settings).equals(IndexVersions.ZERO))) { |
Member
Author
There was a problem hiding this comment.
validateIndexTemplateV2 does index settings validation without necessarily populating the index version. We can either fix that, or bypass the check when the version's missing as above.
sidosera
approved these changes
Mar 10, 2026
romseygeek
approved these changes
Mar 10, 2026
19 tasks
jdconrad
pushed a commit
to jdconrad/elasticsearch
that referenced
this pull request
Mar 11, 2026
…ic#143897) * Disable sequence numbers in TSDB integration tests * [CI] Auto commit changes from spotless * fix compilation test * fix test * fix rest tests --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
jdconrad
pushed a commit
to jdconrad/elasticsearch
that referenced
this pull request
Mar 11, 2026
…ic#143897) * Disable sequence numbers in TSDB integration tests * [CI] Auto commit changes from spotless * fix compilation test * fix test * fix rest tests --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
jdconrad
pushed a commit
to jdconrad/elasticsearch
that referenced
this pull request
Mar 11, 2026
…ic#143897) * Disable sequence numbers in TSDB integration tests * [CI] Auto commit changes from spotless * fix compilation test * fix test * fix rest tests --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
jdconrad
pushed a commit
to jdconrad/elasticsearch
that referenced
this pull request
Mar 11, 2026
…ic#143897) * Disable sequence numbers in TSDB integration tests * [CI] Auto commit changes from spotless * fix compilation test * fix test * fix rest tests --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
jdconrad
pushed a commit
to jdconrad/elasticsearch
that referenced
this pull request
Mar 11, 2026
…ic#143897) * Disable sequence numbers in TSDB integration tests * [CI] Auto commit changes from spotless * fix compilation test * fix test * fix rest tests --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
michalborek
pushed a commit
to michalborek/elasticsearch
that referenced
this pull request
Mar 23, 2026
…ic#143897) * Disable sequence numbers in TSDB integration tests * [CI] Auto commit changes from spotless * fix compilation test * fix test * fix rest tests --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #136305