Skip to content

Extract reroute behavior from create-index request classes#144140

Merged
inespot merged 8 commits intoelastic:mainfrom
inespot:refactor/extract_reroute_behavior
Mar 13, 2026
Merged

Extract reroute behavior from create-index request classes#144140
inespot merged 8 commits intoelastic:mainfrom
inespot:refactor/extract_reroute_behavior

Conversation

@inespot
Copy link
Copy Markdown
Contributor

@inespot inespot commented Mar 12, 2026

The reroute behavior was embedded in CreateIndexClusterStateUpdateRequest and CreateDataStreamClusterStateUpdateRequest, while the reroute listener was passed separately.
This change clarifies the relationship between the two by passing RerouteBehavior alongside the listener as a method parameter.

It also precedes the batched reroute logic in #144074.

Relates to ES-13198.

The reroute behavior was embedded in CreateIndexClusterStateUpdateRequest and CreateDataStreamClusterStateUpdateRequest, while the reroute listener was passed separately. This change clarifies the relationship between the two by passing RerouteBehavior alongside the listener as a method parameter. It also enables the batched reroute logic in elastic#144074.

Relates to ES-13198.
@inespot inespot marked this pull request as ready for review March 13, 2026 02:38
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Mar 13, 2026
@inespot inespot added :Distributed/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >non-issue labels Mar 13, 2026
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team. label Mar 13, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Mar 13, 2026
@inespot inespot requested a review from DaveCTurner March 13, 2026 03:44
Copy link
Copy Markdown
Member

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inespot inespot merged commit b964510 into elastic:main Mar 13, 2026
36 checks passed
szybia added a commit to szybia/elasticsearch that referenced this pull request Mar 13, 2026
…elocations

* upstream/main: (72 commits)
  [Test] Randomly disable sequence numbers in CcrTimeSeriesDataStreamsIT (elastic#143930)
  Fix AsyncSearchIndexServiceTests.testCircuitBreaker failure (elastic#144058)
  Refine GenerativeIT some more, this time with accounting for some added (elastic#144220)
  ESQL: Physical Planning on the Lookup Node (elastic#143707)
  Mute org.elasticsearch.xpack.esql.CsvIT test {csv-spec:approximation.Approximate stats by with zero variance} elastic#144240
  Trigger counter metrics in test for delta temporality measurements (elastic#144193)
  fix capabiltiy approximation_v3 (elastic#144230)
  [ci] Add PR pipeline for testing ipv6 and fix tests not working with ipv6 (elastic#140473)
  update (elastic#144095)
  Make from/to optional in TBUCKET when Kibana timestamp filter is present (elastic#144057)
  Extract reroute behavior from create-index request classes (elastic#144140)
  ESQL: Fix release build only failures (elastic#144122)
  ES|QL query approximation: move sample correction to data node (elastic#144005)
  Add indexing pressure tracking to OTLP endpoints (elastic#144009)
  Fix replica writes after _seq_no doc values are pruned (elastic#144180)
  allow tests to configure supportsLoadingConfig (elastic#144061)
  [ES|QL] Unmute testGiantTextFieldInSubqueryIntermediateResultsWithSort (elastic#144126)
  [ESQL][DOCS] Add CPS page (unpublished for moment) (elastic#144206)
  ESQL: Forbid "load" unmapped_fields for certain commands (elastic#144115)
  Add CCS Remote Views Detection (elastic#143384)
  ...
ncordon pushed a commit to ncordon/elasticsearch that referenced this pull request Mar 16, 2026
…44140)

* Extract reroute behavior from create-index request classes

The reroute behavior was embedded in CreateIndexClusterStateUpdateRequest and CreateDataStreamClusterStateUpdateRequest, while the reroute listener was passed separately. This change clarifies the relationship between the two by passing RerouteBehavior alongside the listener as a method parameter. It also enables the batched reroute logic in elastic#144074.

Relates to ES-13198.

* Re-add deleted comment

* Small fixes

* Missing param in javadoc
michalborek pushed a commit to michalborek/elasticsearch that referenced this pull request Mar 23, 2026
…44140)

* Extract reroute behavior from create-index request classes

The reroute behavior was embedded in CreateIndexClusterStateUpdateRequest and CreateDataStreamClusterStateUpdateRequest, while the reroute listener was passed separately. This change clarifies the relationship between the two by passing RerouteBehavior alongside the listener as a method parameter. It also enables the batched reroute logic in elastic#144074.

Relates to ES-13198.

* Re-add deleted comment

* Small fixes

* Missing param in javadoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >non-issue Team:Distributed Meta label for distributed team. v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants