Removing express dependency#4
Closed
danny-yu wants to merge 655 commits intoeastlondoner:mainfrom
danny-yu:gcloud-functions-gen2
Closed
Removing express dependency#4danny-yu wants to merge 655 commits intoeastlondoner:mainfrom danny-yu:gcloud-functions-gen2
danny-yu wants to merge 655 commits intoeastlondoner:mainfrom
danny-yu:gcloud-functions-gen2
Conversation
…a package's dependency isn't installed (remix-run#2806)
…n#2805) * fix(templates/deno): make `renderToString` export available from `react-dom/server` * fix(templates/deno): pin remix dependency versions to `@latest` * fix(templates/deno): only import a single version of react (18.0.0) upgrading to Remix v1.4.0 makes esm.sh compile Remix deps with React v18.0.0 * fix(templates/deno): typo: `Sign` -> `SignFunction`, `Unsign` -> `UnsignFunction` * fix(templates/deno): running `start` script `node/internal_bindings` is a unstable interface. see denoland/std#2108 * fix(templates/deno): remove `lib`s in Deno's `compilerOptions` fixes remix-run#2402 * fix(templates/deno): app should depend on `remix-deno` runtime, not `@remix-run/server-runtime` * fix(templates/deno): pin remix versions to v1.4.0 now that we are using `deps/`, remix versions are centralized and easy to update
…run#2763) * fix(cli): don't use system path separator on remote repo URLs
* ci(test): set PLAYWRIGHT_BROWSERS_PATH=0 This will download the browser binaries in the node_modules directory and cache them with the package code Signed-off-by: Logan McAnsh <logan@mcan.sh> (cherry picked from commit 652c72f) * ci: update caching Signed-off-by: Logan McAnsh <logan@mcan.sh> (cherry picked from commit ab0c8f8)
…ateFileUploadHandler` example (remix-run#2722)
a copy of remix-run#2780 and remix-run#2789 for dev (cherry picked from commit 8c071d7) (cherry picked from commit a7c6a49)
* Update blog.md * Update docs/tutorials/blog.md * Update docs/tutorials/blog.md * Update docs/tutorials/blog.md Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
* docs: add docs on ?index query param * Fix typo Co-authored-by: Mehdi Achour <machour@gmail.com> * clarify wording * docs: add links from axction, Form, useFetcher sections * remove trailing slash from example Co-authored-by: Mehdi Achour <machour@gmail.com>
Co-authored-by: Mehdi Achour <machour@gmail.com>
* adds windows to our testing workflow * fixes lots of cross-compat testing issues * replaces some snapshot tests w/ direct string checks * fixes bugs in the CLI that should address concerns of Windows users Co-authored-by: Jacob Ebey <jacob.ebey@live.com>
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
…s` (remix-run#184) (remix-run#2944) Improves support for returned links that include an `imagesrcset` attribute to preload images when matched against a responsive set of URLs. This only works when `rel === 'preload'` and `as === 'image'`. https://html.spec.whatwg.org/commit-snapshots/cb4f5ff75de5f4cbd7013c4abad02f21c77d4d1c/#attr-link-imagesrcset Prior to this change, a few problems with our implementation: 1. Our types for `HtmlLinkDescriptor` make `href` required. This is true _unless_ a link includes `imagesrcset` and `imagesizes`, though `imagesrcset` and `href` will also work with or without `imagesizes` according to the spec. This change uses an intersection type to account for these cases. 2. React 17 was released prior to these attributes being accepted into the spec and implemented by browsers, so passing the props as camel-cased will issue a warning about unsupported DOM props. Our types recognized this and supported the all-lowercase version to skip the warning and forward the attribute to the node, but React 18 now recognizes the camel-cased version. This change updates our types to use the camel-cased prop names, but it will support either at runtime and normalize the object based on the detected version of React. 3. Because we use `href` + `rel` as a key, links without an `href` will have duplicate keys. So `imageSrcSet` is added as a fallback to prevent that.
…x-run#3375) Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
* fix(remix-dev): Allow debugging for the remix shorthand * Remove break for default statement Co-authored-by: Michaël De Boey <info@michaeldeboey.be> * refactor dev/default case shared code and fix silly oversight * Use TS shorthand Co-authored-by: Pedro Cattori <pcattori@gmail.com> Co-authored-by: Michaël De Boey <info@michaeldeboey.be> Co-authored-by: Pedro Cattori <pcattori@gmail.com>
GCF adapter for remix 1.3.5 v0.0.7 for remix v1.3.5 v0.0.8 for remix v1.5.1
gcloud deploy version 0.0.3 GCF adapter for remix 1.3.5 v0.0.7 for remix v1.3.5 v0.0.8 for remix v1.5.1 applied PR changes fixes to error handling install @Google-Cloud deps (updates yarn.lock) and remove remix-gcloud-functions-gen2 directory
…orks with jest 27
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
…nd dev dependencies
MichaelDeBoey
pushed a commit
that referenced
this pull request
Aug 3, 2022
* S3 file upload (#1) * Implemented S3 upload * Updated README * Cleaned up dependencies * Revert "S3 file upload (#1)" (#2) This reverts commit df2359c. * S3 file upload (#3) * Implemented S3 upload * Updated README * Cleaned up dependencies * Update contributors.yml * S3 file upload (#4) * Implemented S3 upload * Updated README * Updated README * Cleaned up dependencies * Fixed dependencies * Refactored from useActionData to useFetcher
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented these changes:
remix-run#2266 (comment)
remix-run#2266 (comment)