Skip to content

ci: more nightly updates#2780

Merged
kentcdodds merged 2 commits intomainfrom
logan/more-nightly
Apr 13, 2022
Merged

ci: more nightly updates#2780
kentcdodds merged 2 commits intomainfrom
logan/more-nightly

Conversation

@mcansh
Copy link
Copy Markdown
Contributor

@mcansh mcansh commented Apr 13, 2022 •
edited
Loading

update nightly releases to use version.js script

I'm not sure why we're getting a "dirty" working directory though.. perhaps we just git commit -m "idk man"

Signed-off-by: Logan McAnsh logan@mcan.sh

Closes: #

  • Docs
  • Tests

@mcansh
chore: update nightly scripting
d1192af 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
kentcdodds
kentcdodds requested changes Apr 13, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coolio, just one question

.github/workflows/nightly.yml
Comment on lines +55 to +57
echo "dirty working directory..."
git add .
git commit -m "dirty working directory..."
Copy link
Copy Markdown
Member

@kentcdodds kentcdodds Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there a dirty working directory? What steps trigger file changes?

Copy link
Copy Markdown
Contributor Author

@mcansh mcansh Apr 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great question, that i'd love to have an answer for!

the only files that change during the workflow are package.jsons after running our version script which are immediately committed, and that's done after this check 🤷

in my test repo i was getting a changed package-lock.json, but not sure what the dirtiness is here.

might be fine to leave the commit for a day and see if we can remove it tomorrow after we know what changed?

Copy link
Copy Markdown
Member

@kentcdodds kentcdodds Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 👍

@kentcdodds kentcdodds merged commit 8c071d7 into main Apr 13, 2022
@kentcdodds kentcdodds deleted the logan/more-nightly branch April 13, 2022 21:24
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2022

🤖 Hello there,

We just published version v1.4.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

mcansh added a commit that referenced this pull request Apr 14, 2022
@mcansh
ci: more nightly updates (#2780)
ab6aced 
(cherry picked from commit 8c071d7)
@mcansh mcansh mentioned this pull request Apr 14, 2022
Merged
2 tasks
mcansh added a commit that referenced this pull request Apr 14, 2022
@mcansh
ci: more nightly updates (#2780)
61be703 
(cherry picked from commit 8c071d7)
mcansh added a commit that referenced this pull request Apr 15, 2022
@mcansh
ci: more nightly updates (dev) (#2807)
96d9267 
a copy of #2780 and #2789 for dev

(cherry picked from commit 8c071d7)
(cherry picked from commit a7c6a49)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kentcdodds kentcdodds kentcdodds requested changes

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mcansh @kentcdodds