fix(cli): don't use system path separator on remote repo URLs#2763
Merged
chaance merged 2 commits intoremix-run:devfrom Apr 14, 2022
wKovacs64:wKovacs64/2714-patch
Merged
fix(cli): don't use system path separator on remote repo URLs#2763chaance merged 2 commits intoremix-run:devfrom wKovacs64:wKovacs64/2714-patch
chaance merged 2 commits intoremix-run:devfrom
wKovacs64:wKovacs64/2714-patch
Conversation
Contributor
|
Hi @wKovacs64, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Contributor
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
chaance
approved these changes
Apr 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rolls back a change made in e93f087.
Closes: #2714
The tests don't run on Windows (or at least, not on my machine) - not sure what to do about a related regression test.