Skip to content

tests: remove description & license keys from package.json#3289

Merged
kentcdodds merged 1 commit intoremix-run:devfrom
MichaelDeBoey:remove-unnecessary-package-json-keys-tests
May 24, 2022
Merged

tests: remove description & license keys from package.json#3289
kentcdodds merged 1 commit intoremix-run:devfrom
MichaelDeBoey:remove-unnecessary-package-json-keys-tests

Conversation

@MichaelDeBoey
Copy link
Copy Markdown
Member

Follow-up of #3287

@MichaelDeBoey MichaelDeBoey marked this pull request as draft May 22, 2022 17:48
Copy link
Copy Markdown
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be a draft? It's good to go IMO 👍

@MichaelDeBoey MichaelDeBoey marked this pull request as ready for review May 24, 2022 07:57
@MichaelDeBoey MichaelDeBoey requested a review from kentcdodds May 24, 2022 07:58
Copy link
Copy Markdown
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit b96864e into remix-run:dev May 24, 2022
@MichaelDeBoey MichaelDeBoey deleted the remove-unnecessary-package-json-keys-tests branch May 24, 2022 13:16
@github-actions
Copy link
Copy Markdown
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-48fe580-20220525 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

justjavac pushed a commit to justjavac/remix that referenced this pull request Jun 11, 2022
@github-actions
Copy link
Copy Markdown
Contributor

🤖 Hello there,

We just published version v1.6.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants