Skip to content

chore: add engines field to package.json#3360

Merged
kentcdodds merged 1 commit intoremix-run:devfrom
MichaelDeBoey:add-engines-to-packages
Jun 1, 2022
Merged

chore: add engines field to package.json#3360
kentcdodds merged 1 commit intoremix-run:devfrom
MichaelDeBoey:add-engines-to-packages

Conversation

@MichaelDeBoey
Copy link
Copy Markdown
Member

@MichaelDeBoey MichaelDeBoey commented Jun 1, 2022

No description provided.

kentcdodds
kentcdodds approved these changes Jun 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit a7bff8b into remix-run:dev Jun 1, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 2, 2022

🤖 Hello there,

We just published version v0.0.0-nightly-a7bff8b-20220602 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@MichaelDeBoey MichaelDeBoey deleted the add-engines-to-packages branch June 2, 2022 07:39
@MichaelDeBoey MichaelDeBoey mentioned this pull request Jun 7, 2022
Merged
justjavac pushed a commit to justjavac/remix that referenced this pull request Jun 11, 2022
@MichaelDeBoey @justjavac
chore: add engines field to package.json (remix-run#3360)
88254f1
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 14, 2022

🤖 Hello there,

We just published version v1.6.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@Dmitry-Sokolov
Copy link
Copy Markdown

Dmitry-Sokolov commented Dec 26, 2022

@MichaelDeBoey Could you please help, why did you put 14 and not 12? Do you have some special requirements for the node js? I try to run on the 12 version and it works, so I wonder, why 14?

@machour
Copy link
Copy Markdown
Contributor

machour commented Dec 26, 2022

@Dmitry-Sokolov Officially, Remix supports Node version ^14.17.0, or >=16.0.0

@Dmitry-Sokolov
Copy link
Copy Markdown

Dmitry-Sokolov commented Dec 26, 2022

Thank you @machour
Need to say, that 6.6.1 can work with the last 12 node js, just need to make the correct configuration for dev dependencies and some other small fixes, in any case, not all old projects can be super fast upgrade nodes :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees

@kentcdodds kentcdodds

Labels

CLA Signed renderer:react

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MichaelDeBoey @Dmitry-Sokolov @machour @kentcdodds