chore(remix-eslint-config): cleanup peerDependencies#2742
Merged
chaance merged 1 commit intoremix-run:devfrom Apr 17, 2022
Merged
chore(remix-eslint-config): cleanup peerDependencies#2742chaance merged 1 commit intoremix-run:devfrom
peerDependencies#2742chaance merged 1 commit intoremix-run:devfrom
Conversation
MichaelDeBoey
commented
Apr 11, 2022
| "eslint": ">=8.1.0", | ||
| "react": ">=17.0.0", | ||
| "react-dom": ">=17.0.0" | ||
| "eslint": "^8.0.0", |
Member
Author
There was a problem hiding this comment.
Nothing is keeping us from using v8.0.0 instead of v8.1.0
MichaelDeBoey
force-pushed
the
cleanup-ESLint-config-peerDependencies
branch
from
54d2467 to
a8ff344
Compare
MichaelDeBoey
force-pushed
the
cleanup-ESLint-config-peerDependencies
branch
from
a8ff344 to
0942dbe
Compare
chaance
suggested changes
Apr 17, 2022
Contributor
chaance
left a comment
chaance
left a comment
There was a problem hiding this comment.
If we could address https://github.com/remix-run/remix/pull/2742/files#r851759590 I'll merge. Thanks!
chaance
approved these changes
Apr 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also added
enginesfor convenience