Merged
Conversation
Another example, to make it easier to discover how to accomplish tracking of latency communicated through response headers when using Nighthawk. Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Required changes: - signature change for how envoy creates files - a new enum value (ProtocolError) needed to be accounted for in streamResetReasonToResponseFlag - check_format script in envoy moved - error message for integer out of range in protos was modified slightly - made it less specific to fix Other necessary changes not necessarily caused by update - Fixed an environment-sensitivity issue where time_since_epoch doesn't.count() wasn't reliably nanoseconds - In some environments (including mine), request source tests were failing because they couldn't find the files - fixed by adding fileset to BUILD Signed-off-by: Nathan Perry <nbperry@google.com>
- Adds an in-memory sink. Comes in handy in tests, and could serve a future role if we want to converge the way results are handled in both distributed and non-distributed tests. - Slightly refactors validation & testing to make it easier to see what is specific to FileSinkImpl, making things a little more natural in case someone else wants to add a new sink type in the future. - Avoid MOCK_METHOD_N in the Sink mock as per recommendation. Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Another prelude to distributed test execution. Being able to identify executions and associate results is going to come in handy. Also, this separates some BUILD targets to allow for a leaner build process of future things that are going to depend on it. Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Part of the horizontal scaling effort: `SimpleStatistic` and `StreamingStatistic ` get used for tracking header byte counts, hence we should be able to wire transfer statistics for those to be able to properly aggregate. Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Fixes #625 Replacing getJsonStringFromMessageOrDie() by getJsonStringFromMessageOrError(). Signed-off-by: Rajdeep Roy Chowdhury <rrajdeeproychowdhury@gmail.com>
* Bump pyyaml from 5.3.1 to 5.4 Bumps [pyyaml](https://github.com/yaml/pyyaml) from 5.3.1 to 5.4. - [Release notes](https://github.com/yaml/pyyaml/releases) - [Changelog](https://github.com/yaml/pyyaml/blob/master/CHANGES) - [Commits](yaml/pyyaml@5.3.1...5.4) Signed-off-by: dependabot[bot] <support@github.com> * deflake Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Otto van der Schaaf <ovanders@redhat.com> Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
* Sink tests: fix for parallel test execution FileSinkTest.CorruptedFile would flake when running multiple instances of it concurrently. This PR tweaks it to avoid that. Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Signed-off-by: jiajunye <jiajunye@google.com>
When there is a URI exception or failing failure predicate, log troubleshooting tips and return the tips in the Nighthawk Service error description. Add a default failure predicate for benchmark.stream_resets > 0, since stream resets usually indicate a misconfigured protocol. NOTE: If you expect stream resets in a benchmark session, run with --failure-predicate benchmark.stream_resets:1000000000 to avoid early termination. Related to #181 and #613. Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
This wires in a lot of the gRPC Sink service functionality, but not all of it. I trimmed it down somewhat so we can focus on wiring in most of the flesh of it in a bite sized review. Summarising statistics & handling of chunks of raw statistics data will be added in one or more follow-ups to this. Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Followed instructions from: https://github.com/envoyproxy/nighthawk/blob/main/MAINTAINERS.md#updates-to-the-envoy-dependency Tests passed, no changes required. Signed-off-by: William Juan <66322422+wjuan-AFK@users.noreply.github.com>
Add aarch64 Bazel build options for GCC toolchain which would enable the test_gcc for ci script on arm platform. Signed-off-by: trevor tao <trevor.tao@arm.com>
Signed-off-by: eric846 <56563761+eric846@users.noreply.github.com>
- Sync .bazelrc - Update Docker image version in .circleci/config.yml - ci/run_envoy_docker.sh was unchanged - Code changes - Remove `response->waitForEndStream();` from `HttpFilterIntegrationTestBase::getResponse()` in test/server/http_filter_integration_test_base.cc due to envoyproxy/envoy#15972. We can't simply change it to `ASSERT_TRUE(response->waitForEndStream());` in `HttpFilterIntegrationTestBase::getResponse()` since this will cause error: ``` test/server/http_filter_integration_test_base.cc:69:5: error: no viable conversion from returned value of type 'void' to function return type 'Envoy::IntegrationStreamDecoderPtr' (aka 'unique_ptr<Envoy::IntegrationStreamDecoder>') ASSERT_TRUE(response->waitForEndStream()); ``` - Added `ASSERT_TRUE(response->waitForEndStream());` to all places where `HttpFilterIntegrationTestBase::getResponse()` is called in the tests. Signed-off-by: qqustc@gmail.com <qqin@google.com>
Part of the horizontal scaling effort: add gRPC distributor service + tests. This new gRPC service allows delegation of load test execution initiation messages to a set of load generator services. Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Fix two typos. Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.