Update Envoy to 751be72 (April 19th 2021)#674
Merged
mum4k merged 3 commits intoenvoyproxy:mainfrom Apr 20, 2021
Merged
Conversation
mum4k
approved these changes
Apr 20, 2021
wjuan-AFK
pushed a commit
to wjuan-AFK/nighthawk
that referenced
this pull request
May 11, 2021
- Sync .bazelrc - Update Docker image version in .circleci/config.yml - ci/run_envoy_docker.sh was unchanged - Code changes - Remove `response->waitForEndStream();` from `HttpFilterIntegrationTestBase::getResponse()` in test/server/http_filter_integration_test_base.cc due to envoyproxy/envoy#15972. We can't simply change it to `ASSERT_TRUE(response->waitForEndStream());` in `HttpFilterIntegrationTestBase::getResponse()` since this will cause error: ``` test/server/http_filter_integration_test_base.cc:69:5: error: no viable conversion from returned value of type 'void' to function return type 'Envoy::IntegrationStreamDecoderPtr' (aka 'unique_ptr<Envoy::IntegrationStreamDecoder>') ASSERT_TRUE(response->waitForEndStream()); ``` - Added `ASSERT_TRUE(response->waitForEndStream());` to all places where `HttpFilterIntegrationTestBase::getResponse()` is called in the tests. Signed-off-by: qqustc@gmail.com <qqin@google.com> Signed-off-by: William Juan <66322422+wjuan-AFK@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
response->waitForEndStream();fromHttpFilterIntegrationTestBase::getResponse()in test/server/http_filter_integration_test_base.cc due to test: making assert required envoy#15972. We can't simply change it toASSERT_TRUE(response->waitForEndStream());inHttpFilterIntegrationTestBase::getResponse()since this will cause error:ASSERT_TRUE(response->waitForEndStream());to all places whereHttpFilterIntegrationTestBase::getResponse()is called in the tests.Signed-off-by: qqustc@gmail.com qqin@google.com