Enable test_gcc on arm64 platform for ci#672
Merged
mum4k merged 1 commit intoenvoyproxy:mainfrom Apr 12, 2021
Merged
Conversation
Add aarch64 Bazel build options for GCC toolchain which would enable the test_gcc for ci script on arm platform. Signed-off-by: trevor tao <trevor.tao@arm.com>
oschaaf
approved these changes
Apr 12, 2021
Member
oschaaf
left a comment
oschaaf
left a comment
There was a problem hiding this comment.
This is great. I think we are lacking the right CI env to test this, correct? Did you test the resulting binaries manually?
Contributor
Author
Yes, I tested it in my local environment. Thanks. |
Contributor
Author
|
mum4k
approved these changes
Apr 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add aarch64 Bazel build options for GCC toolchain
which would enable the test_gcc for ci script on
arm platform.
Signed-off-by: trevor tao trevor.tao@arm.com