Sink: add in memory sink, slightly refactor validation/testing.#657
Merged
mum4k merged 3 commits intoenvoyproxy:mainfrom Mar 23, 2021
Merged
Sink: add in memory sink, slightly refactor validation/testing.#657mum4k merged 3 commits intoenvoyproxy:mainfrom
mum4k merged 3 commits intoenvoyproxy:mainfrom
Conversation
- Adds an in-memory sink. Comes in handy in tests, and could serve a future role if we want to converge the way results are handled in both distributed and non-distributed tests. - Slightly refactors validation & testing to make it easier to see what is specific to FileSinkImpl, making things a little more natural in case someone else wants to add a new sink type in the future. - Avoid MOCK_METHOD_N in the Sink mock as per recommendation. Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Collaborator
|
@jiajunye please review and assign back to me once done. |
Contributor
|
LGTM |
mum4k
requested changes
Mar 23, 2021
mum4k
added
waiting-for-changes
Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Member
Author
oschaaf
added
waiting-for-review
Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
mum4k
approved these changes
Mar 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a future role if we want to converge the way results are handled
in both distributed and non-distributed tests.
what is specific to FileSinkImpl, making things a little more
natural in case someone else wants to add a new sink type in the
future.
Signed-off-by: Otto van der Schaaf ovanders@redhat.com