test: making assert required#15972
Merged
mattklein123 merged 4 commits intoenvoyproxy:mainfrom Apr 15, 2021
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
apologies for force push - screwed up local state somehow |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
repokitteh-read-only
bot
added
the
deps
Contributor
|
@alyssawilk Hello, have you solved the ci flakes of |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
@qinggniq sorry about that - ironically the new ASSERT was designed to catch timeouts like this, I just didn't realize that test was already broken! |
Contributor
Author
|
To confirm, CI is happy with this hash, sorry about the temporary breakage! |
douglas-reid
pushed a commit
to douglas-reid/envoy
that referenced
this pull request
Apr 19, 2021
Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>
Monkeyanator
pushed a commit
to Monkeyanator/envoy
that referenced
this pull request
Apr 20, 2021
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
mum4k
pushed a commit
to envoyproxy/nighthawk
that referenced
this pull request
Apr 20, 2021
- Sync .bazelrc - Update Docker image version in .circleci/config.yml - ci/run_envoy_docker.sh was unchanged - Code changes - Remove `response->waitForEndStream();` from `HttpFilterIntegrationTestBase::getResponse()` in test/server/http_filter_integration_test_base.cc due to envoyproxy/envoy#15972. We can't simply change it to `ASSERT_TRUE(response->waitForEndStream());` in `HttpFilterIntegrationTestBase::getResponse()` since this will cause error: ``` test/server/http_filter_integration_test_base.cc:69:5: error: no viable conversion from returned value of type 'void' to function return type 'Envoy::IntegrationStreamDecoderPtr' (aka 'unique_ptr<Envoy::IntegrationStreamDecoder>') ASSERT_TRUE(response->waitForEndStream()); ``` - Added `ASSERT_TRUE(response->waitForEndStream());` to all places where `HttpFilterIntegrationTestBase::getResponse()` is called in the tests. Signed-off-by: qqustc@gmail.com <qqin@google.com>
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 6, 2021
Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Gokul Nair <gnair@twitter.com>
wjuan-AFK
pushed a commit
to wjuan-AFK/nighthawk
that referenced
this pull request
May 11, 2021
- Sync .bazelrc - Update Docker image version in .circleci/config.yml - ci/run_envoy_docker.sh was unchanged - Code changes - Remove `response->waitForEndStream();` from `HttpFilterIntegrationTestBase::getResponse()` in test/server/http_filter_integration_test_base.cc due to envoyproxy/envoy#15972. We can't simply change it to `ASSERT_TRUE(response->waitForEndStream());` in `HttpFilterIntegrationTestBase::getResponse()` since this will cause error: ``` test/server/http_filter_integration_test_base.cc:69:5: error: no viable conversion from returned value of type 'void' to function return type 'Envoy::IntegrationStreamDecoderPtr' (aka 'unique_ptr<Envoy::IntegrationStreamDecoder>') ASSERT_TRUE(response->waitForEndStream()); ``` - Added `ASSERT_TRUE(response->waitForEndStream());` to all places where `HttpFilterIntegrationTestBase::getResponse()` is called in the tests. Signed-off-by: qqustc@gmail.com <qqin@google.com> Signed-off-by: William Juan <66322422+wjuan-AFK@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up on #15812 and envoyproxy/envoy-filter-example#143
Risk Level: n/a (test only)
Testing: n/a
Docs Changes: n/a
Release Notes: n/a