SimpleStatistics: implement serialization roundtrip#659
Merged
mum4k merged 5 commits intoenvoyproxy:mainfrom Mar 24, 2021
Merged
SimpleStatistics: implement serialization roundtrip#659mum4k merged 5 commits intoenvoyproxy:mainfrom
mum4k merged 5 commits intoenvoyproxy:mainfrom
Conversation
Part of the horizintal scaling effort: simplestatistics get used for tracking header byte counts, hence we should be able to wire transfer statistics for those to be able to properly aggregate. Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Member
Author
|
Perhaps not obvious when looking at the code changes here, but test coverage for this is in place via |
Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Collaborator
|
@qqustc please review and assign back to me when done. |
qqustc
reviewed
Mar 23, 2021
added 2 commits
March 23, 2021 21:22
…zation-roundtrip Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
mum4k
requested changes
Mar 24, 2021
mum4k
added
waiting-for-changes
Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
oschaaf
added
waiting-for-review
mum4k
approved these changes
Mar 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the horizontal scaling effort:
SimpleStatisticandStreamingStatisticget usedfor tracking header byte counts, hence we should be able to wire
transfer statistics for those to be able to properly aggregate.
Signed-off-by: Otto van der Schaaf ovanders@redhat.com