Repository navigation
fix: repair guarded transport and release CI contracts - #16420
diegosouzapw merged 15 commits into
Conversation
Resolve .i18n-state.json by taking the release branch state (cheaper-inference#15840 round 2 refresh); the branch's own copy carried stale hashes and npm run i18n:check passes on the merged tree without it.
|
Merged Local evidence on the merged candidate (
No code changed beyond the merge commit; authorship stays yours. Handing the PR to the maintainer for the merge decision. |
|
Filed #16488 for the transport part of this PR: on The issue has a standalone repro (Node 24's built-in |
stryker.conf.json: keep both sides of tap.testFiles (the branch's six fixtures plus combo-pinned-empty-turn, and the release tip's account-weighted-runtime-16459 and memory-extraction-pii-sanitization entries), and add the two covering tests the release tip itself omits (repo-checks-isolate-datadir from cheaper-inference#16353, combo-model-lock-pre-dispatch-wait-16319 from cheaper-inference#16360) so check:mutation-test-coverage --strict passes on the merged tree.
|
Second sync with Re-validated locally on Hosted CI is queued behind ~300 runs from today's merge campaign; lanes will report when the queue drains. |
|
Independent Relay closeout diagnostic (2026-10-13): this front has not modified #16420 or your active Fresh focused results on that exact combination:
These failures overlap the scope described in #16420 and the narrower #16059/#16150. They are current-combination diagnostics, not an exact pure-base attribution and not evidence that #16420 is accepted. Please coordinate candidate validation/landing with the existing owners before new duplicate repairs are created. This front has not imported this PR wholesale, approved its workflow/allowlist/generated-instruction changes, or bypassed any required gate. Separate narrowly approved observer correction #16533 now rejects incomplete/cancelled complexity results without changing baselines or advisory measured-drift policy. That does not fix or waive these product/fixture failures. |
|
Relay closeout coordination, 2026-10-14: the repository owner has now explicitly authorized including #16420 in this campaign's review/integration scope, alongside the new ENVIRONMENT locale delta. This does not waive any required gate or transfer your active worktree. Current readback: release I own #16504 and will update its actual ENVIRONMENT translations for #16510's CODEBUDDY_SYSTEM_PROMPT_MAX_LEN row, preserving source/target evidence rather than adopting hashes. Please avoid parallel edits to that PR. #15945/#15948 and the narrower #16482/#16059/#16150 overlaps remain separately owned/open; no contributor PR will be closed or bypassed by this front. |
|
Independent review of exact head Scoped diagnostics in our isolated review worktree, Node 24.20.0 / npm 11.15.0, matching lock SHA256
Outstanding acceptance findings:
Thanks for the guarded-transport repair and fixture reconciliation. The local positives above are scoped evidence only, not merge approval or a declaration that the release is green. |
|
Follow-up on the same head
These are retained current-candidate failure signatures, not proven fixture defects or BASE-RED classifications; no baselines, assertions or auth requirements were weakened. #16504 now publishes the real 66-locale ENVIRONMENT delta at |
e369ffc
into
cheaper-inference:release/v3.8.52
Summary
Preserve guarded direct egress across native Node fetch's legacy handlers and Undici 8's modern handlers. The installed public dispatcher bridge adapts only legacy callbacks; modern handler identity/options pass through unchanged. No added retries, account changes, protocol downgrade for modern clients, or DNS/private-address guard relaxation.
The release-CI follow-up retains locale refresh ordering, extracted dashboard connection types, existing attempt-options extraction, hosted webpack fallback and c8 incremental shard merging. Stronger current upstream AST, shell-boundary, policy-eligible, signed-in-session and lossless-image fixtures are preserved. The dashboard row's existing status presentation is extracted without changing its logic. Four missing mutation discovery entries are restored without changing thresholds.
Current verification
Candidate:
93c5ca5075df90449d359d1d4d93d39a334e628d, reconciled with release base2c06e3c0cb68464379dfdc9a828a1e9868887aaf.Earlier exact candidate
a044c0d8f2passed focused acceptance run 38638728927: original boundary RED (invalid onRequestStart), final 15/15 GREEN, generator idempotence and Linux translation hashes passed (330 explicitly stale locales). Full CI then proved a leftover fixture setup setexcludeTosAvoid=falsebefore asserting the upstream default is true; this replacement removes only that obsolete setup and retains every assertion. Replacement focused acceptance run 38645328781 now also passed on exact93c5ca5075: original boundary RED, final15/15 GREEN, generator0changed/46unchanged/0errors and Linux translation hashesPASS with396 explicitly stale locales. Full acceptance is blocked by inherited APItypecheckTS2345 and other baseline failures.93c5ca5075in focused hosted acceptance.93c5ca5075(46 unchanged).Inherited base failures
The previous candidate's failed jobs were inspected against the reconciled base. The
MODEL_VARIANTdocumentation gap and extracted quota-wiring assertion loss are resolved by upstream changes. Four unrelated inherited failures remain in unchanged upstream source/fixtures:messages-count-tokens-route.test.ts: dotted model expectation conflicts with the canonical dashed model ID.rate-limiter-backup-flag-not-test-mode.test.ts: second-request fallback assertion failed; a real-time fixed-window boundary is a possible cause, not a demonstrated production bypass.model-test-route.test.ts: internal request lacks strict-mode authentication; existing contributor PR fix(api): authenticate the in-process model test under REQUIRE_API_KEY #16589 addresses this separately.video-raw-transcript-retention-12430.test.ts: raw-transcript preservation assertions conflict with the newer content-part field allowlist.Newer base reconciliation also exposes inherited TS2345 in
openai-responses.tsfrom #16539, four inherited file-size overages, and the Antigravity mock's empty project result. Their source is unchanged from the release base. These are not silently fixed inside this contribution or treated as green. Exact-candidate CI is required before acceptance.Scope and rollback
Normal revert; no DB migration or dependency upgrade. Separate from native image PR #15524. No installed gateway update/restart, paid model substitution, provider inference probe or upstream merge was performed. Existing security/auth/account-selection behavior stays intact.