Skip to content

fix(quality): reject incomplete complexity gate outcomes - #16533

Merged
diegosouzapw merged 1 commit into
release/v3.8.52from
fix/release-green-complexity-outcomes-20261013
Oct 13, 2026
Merged

diegosouzapw merged 1 commit into
release/v3.8.52from
fix/release-green-complexity-outcomes-20261013

Conversation

@diegosouzapw

Copy link
Copy Markdown
Collaborator

Summary

Fix the release-green observer's handling of the shared complexity walk. Its old inline parser discarded the command exit and could emit two passing drift records after cancellation or incomplete output. The outer execution-receipt guard still rejected that cancelled run; this repair removes the contradictory per-metric PASS and also rejects incomplete successful output.

  • Preserve the actual process result when interpreting complexity measurements.
  • Require both complete, finite machine counts and their matching ratchet summaries. The generic legacy N violações parser cannot substitute cyclomatic data for a missing cognitive measurement.
  • Classify cancellation, timeout, crashes, missing/invalid metrics and unknown baseline as hard execution failures.
  • Preserve the existing advisory policy for complete, measured cognitive/cyclomatic drift, including its expected exit 1.
  • No baseline, threshold, dependency, workflow, generated-instruction or application-runtime changes.

Evidence and validation

  • Reproduced the original cancellation false-PASS after extracting the original inline logic unchanged: regression test FAIL before the fix, PASS after it.
  • Expanded RED reproduced partial and malformed output being accepted by the old fallback/parser.
  • Focused/affected suites: 83 passed, 0 failed, 0 skipped, 0 cancelled, covering the observer helpers, gate process/receipts, workflow verdicts, documentation regressions and the new complexity outcomes.
  • Includes a real supervised subprocess cancellation and immutable receipt assertion, not only fabricated return objects.
  • Explicit eslint --no-ignore for both changed code/test files: exit 0.
  • Prettier and changelog integrity against the pinned base: exit 0.
  • Normal local commit hooks are retained. Full applicable remote CI is still required; focused evidence is not merge admission.

Pinned development base: 2aa7ccbd3ff8a1efc58a745d44d62084b741b2c1 on release/v3.8.52. The release is advancing concurrently, so no claim is made that these local diagnostics certify a later combined merge candidate. Dependency files are unchanged; focused runs use physical dependencies copied from a completed clean install with the identical lockfile, not a separate clean-install certification of this worktree.

Authorization and scope

This is the specifically owner-approved validator repair discovered while closing the Relay CLI delivery campaign. It is independent of #15945/#15948 (other active owner), #15682 and #16504, and does not take over those branches. A separately based main companion is being prepared; neither this PR nor that companion is authorized to bypass required checks.

@diegosouzapw
diegosouzapw merged commit ad01434 into release/v3.8.52 Oct 13, 2026
12 of 13 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

CI Coverage Report

  • Coverage job: skipped
  • PR test policy: success

Coverage artifact was not available for this run.

diegosouzapw added a commit that referenced this pull request Oct 14, 2026
Main-side companion of #16533 (merged into release/v3.8.52). Validated against origin/main: tests/unit/build/release-green-complexity-outcomes.test.ts 22/22, eslint clean on the changed files, changelog-integrity green.
@diegosouzapw
diegosouzapw deleted the fix/release-green-complexity-outcomes-20261013 branch October 18, 2026 23:50
arashashrafii pushed a commit to arashashrafii/OmniRoute that referenced this pull request Oct 24, 2026
…inference#16536)

Main-side companion of cheaper-inference#16533 (merged into release/v3.8.52). Validated against origin/main: tests/unit/build/release-green-complexity-outcomes.test.ts 22/22, eslint clean on the changed files, changelog-integrity green.

(cherry picked from commit fd95f82)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant