Repository navigation
fix(translator): type the pending Responses tool-call id as a string (api-typecheck base-red) - #16624
Merged
diegosouzapw merged 2 commits intoOct 15, 2026
Conversation
check:api-typecheck on release/v3.8.52 fails since #16539 with open-sse/translator/request/openai-responses.ts(374,74) TS2345: the role-based tool calls are JsonRecord[], so toolCall.id is unknown and cannot be pushed into pendingCallIds: string[]. normalizeRoleBasedToolCalls() already guarantees a non-empty string id, so coerce it with toString() at the push site. RED: node scripts/check/check-api-typecheck.mjs -> FAIL (baseline 0, live 1) GREEN: same gate -> OK, 256 pre-existing errors within the frozen baseline; 373 translator unit tests pass under the test:unit:ci preamble.
diegosouzapw
pushed a commit
that referenced
this pull request
Oct 14, 2026
Base-red repair for release/v3.8.52 (#15306): undici 8 guarded dispatcher bridge, executeTargetAttempt type extraction (file-size), c8 incremental coverage merge, hosted webpack build fallback, and realignment of the unit/e2e fixtures the release contracts had outgrown. Locally validated on the merged head: 13 of the 14 unit assertions red on the pure tip pass, check:mutation-test-coverage and check:file-size (executeTargetAttempt) pass; the remaining reds on this head are release-tip base-reds (API typecheck #16624, four other file-size overages, count_tokens and model-test route fixtures). Refs #15306
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
Collaborator
Author
|
Added three regression scenarios in
Validation:
The same local API gate on pure base This resolves the scoped missing-test/typecheck work. Full merge admission remains HOLD pending the other required checks and the release-base repairs. No baseline widening, timeout changes, administrative bypass, or merge was performed. |
This was referenced Oct 15, 2026
diegosouzapw
added a commit
that referenced
this pull request
Oct 16, 2026
…heck (base-red #15306)⚠️ base-red inherited: #15306 After #16624 landed, api-typecheck still failed on the tip with nine new TS2339s (`strict: false` does not narrow `if (!parsed.ok)` on the IntegerParam / CopilotAutoResolution unions, plus `Transformer.cancel` on sseOutputSink). ## Proof - `node scripts/check/check-api-typecheck.mjs` → OK, 255 pre-existing, no new regressions - `tests/unit/mgmt-list-params-validation.test.ts` → 19/19 Does not widen `config/quality/api-typecheck-baseline.json`. Thanks @diegosouzapw.
diegosouzapw
deleted the
fix/release-v3.8.52-basereds-api-typecheck-20261014
branch
October 18, 2026 23:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check:api-typecheckhas been red onrelease/v3.8.52since #16539 landed (ab1abecf26):open-sse/translator/request/openai-responses.ts(374,74) TS2345 — Argument of type 'unknown' is not assignable to parameter of type 'string'.normalizeRoleBasedToolCalls()returnsJsonRecord[], sotoolCall.idis typedunknowneven though the helper already guarantees a non-empty string id. This coerces it withtoString()at the single push site intopendingCallIds: string[]. No behavior change.The gate fails on the pure tip (
2c06e3c0cb) and on every PR targeting the release, including #16420's current head.Validation (hermetic env, isolated worktree on the tip)
node scripts/check/check-api-typecheck.mjs→FAIL — 1 new/regressed TypeScript error(s) … openai-responses.ts TS2345 (baseline 0, live 1)OK — 256 pre-existing error(s), all within frozen baselineopenaiResponsesToOpenAIRequest, run with the exacttest:unit:cipreamble: 373 passRefs #15306