Repository navigation
fix(i18n): refresh after detecting a different initial locale - #16059
Conversation
|
Fechando esta PR para esvaziar a fila aberta. A branch |
|
Reabrindo. O fechamento foi um engano; esta PR volta para a fila de merge. A branch continua no lugar. |
|
Reconciled this original PR with release The runtime ordering fix is already present in that release via #16420. The remaining useful change is the regression checking that the locale cookie, local storage, HTML language and text direction are persisted before
The PR remains draft and is not merge-admitted: required current-candidate CI and the release repair dependencies remain outstanding. No queue label or merge was applied. |
Preserve current runtime implementation and rerun the actual UI collector: LocaleAutoDetect refresh 5/5 pass on release ad37e8f.
Relay continuation — scoped reconciliation, not merge acceptanceThanks the locale-refresh contributors. Reconciled this original PR with pinned release 5/5 tests PASS with the actual Vitest UI collector, including locale persistence before refresh. Production behavior already in the base is preserved. Node 24.20.0 / npm 11.15.0; unchanged lockfile SHA-256 |
CI Coverage Report
Coverage artifact was not available for this run. |
Summary
Capture the server-rendered
html.langbeforepersistLocaleupdates the DOM, so a genuinely different detected locale refreshes server-rendered content. Preserve the no-refresh case when the locale already matches.The public-boundary regression observes cookie, localStorage,
html.langand RTL direction whennext/navigationreceives the refresh, using real detection/persistence. Test roots are unmounted inside act. No threshold, timeout or assertion was relaxed.Current validation — 2026-10-10
Head
2da6fba077aabff3de94a0d59bee6bfcd35d2f5a, including a normal merge of base7510677f2f8f5317f1947284dab650d01333915d. Diff remains only the two locale files. Normal hooks PASS, no force-push.--maxWorkers=2(default config is four). This supersedes the historical 494/499 timeout run, but does not prove the default runner configuration.Admission limits
Related to #15306. Draft / HOLD. The remote release base advanced to
cc84e9426ac3e8d34e8dde8bb2e081305ae886d9; existing receipts do not certify that new candidate. Full Node, coverage, security, build/package/boot and current required CI remain necessary. No merge, bypass, ruleset activation or deployment was performed.