Skip to content

fix: preserve native image references and model routing - #15524

Closed
KiaroSama wants to merge 44 commits into
cheaper-inference:release/v3.8.52from
KiaroSama:fix/native-image-editing
Closed

KiaroSama wants to merge 44 commits into
cheaper-inference:release/v3.8.52from
KiaroSama:fix/native-image-editing

Conversation

@KiaroSama

@KiaroSama KiaroSama commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Native image generation and editing must honor the selected model, account and original reference bytes. Dedicated Codex image models use native Images endpoints; Antigravity edits preserve original inline-image inputs. Unsupported masks/output controls, model/paid-plan admission, MIME/cardinality/byte limits and API-key connection restrictions remain enforced. Unknown submitted outcomes remain terminal instead of silently rotating accounts/models or repeating a paid submission.

Reconciled this existing contribution with release base 32130fca348767f97bdd976ce4c5db876675125a using normal merge commit 9ecc3e32ee2fa444bc535a695a616713c58c930d. Both histories are preserved and all 13 conflicting paths are resolved. Incoming bounded one-image-provider fanout, deliberate BFL num_images removal, build-warning extraction and per-attempt image accounting remain in their owning modules; oversized registry/handler monoliths are not restored.

Dedicated native route attempts retain one metadata-only call log and successful priced usage record, attributed to the selected connection/API key. Request/response bodies and upstream failure details are withheld from that dedicated log. The native transport stays state-free. Incoming Sunburst fixtures now use the retained OAuth/access-token and identity-header contract; no production guard was relaxed for a fixture.

Current evidence

  • Local/fork/PR heads match 9ecc3e32ee2fa444bc535a695a616713c58c930d; GitHub reports this PR mergeable. Mergeability is not passing CI.
  • Semantic TypeScript validation over eight real image/fixture roots and transitive imports: zero diagnostics. Scoped suppression-aware ESLint passed. Directly integrated source/test files remain below 800 lines.
  • Public route regression reproduced missing call history (0 !== 1), then passed: four direct/combo generation/edit successes produce four submissions, four call logs and four usage records. A terminal 401 adds one rejected submission/log, no successful usage and no repeated submission. Exact native model/auth/workspace/reference bytes and original response remain checked; dedicated log bodies are null.
  • Two focused Sunburst generation/edit fixtures passed. These light checks used isolated project data/home, fake upstreams, one worker, native timeouts, 45-second wall/20-second idle bounds and verified owned-process cleanup. No full local suite/build or real provider call was run.
  • Native commit gates passed: identity, lint-staged without stash, formatting/ESLint, documentation sync, explicit-any budgets, tracked artifacts and metadata attribution. One measured stale suppression was removed; no gate bypass or threshold increase.
  • Independent source review identified the Sunburst fixture mismatch and missing dedicated call logs. Both corrections were subsequently reviewed and approved in that limited scope.

Hosted acceptance — blocked, not green

Final image workflow dispatch was attempted after publication and rejected:

HTTP 422: Actions has been disabled for this repository.

The permissions API separately reports Actions enabled, and the registered image workflow is absent from the fork's default branch. These conflicting observations do not establish an operational manual run. No account, billing, visibility, runner or Actions setting was changed. The image workflow now has only a manual initiating trigger; no automatic image build was requested.

Historical successful image/Windows runs are not evidence for this merged SHA. Current upstream PR checks are separate and pending; full unit/Vitest/coverage/backend/Windows acceptance remains open.

Merge danger

Two-way door: ordinary code revert. This image contribution adds no schema migration or runtime dependency.

Blast radius: image admission, direct/combo generation/edit dispatch, accounting attribution and image fixtures. Account entitlement and actual native output dimensions remain separately unverified. The installed gateway, configuration/data and other sessions remain untouched. Updating this contribution does not authorize merging the upstream PR or activating a replacement runtime.

@diegosouzapw

Copy link
Copy Markdown
Collaborator

Hi @KiaroSama — closing this pull request to clear the open queue. The branch fix/native-image-editing is kept, so the commits stay. Comment here if it should be reopened.

@diegosouzapw

Copy link
Copy Markdown
Collaborator

Hi @KiaroSama — reopening this pull request. The close was a mistake, and it is back in the merge queue. The branch fix/native-image-editing was kept.

@diegosouzapw diegosouzapw reopened this Oct 10, 2026
@KiaroSama
KiaroSama marked this pull request as ready for review October 11, 2026 22:43
@KiaroSama
KiaroSama force-pushed the fix/native-image-editing branch from f817812 to 918e5f3 Compare October 12, 2026 16:47
@diegosouzapw

Copy link
Copy Markdown
Collaborator

Thanks @KiaroSama for the image-routing work. This branch can't land as a whole: it deletes CLAUDE.md, adds /AGENTS.md /CLAUDE.md /.agents/ /.claude/ to .gitignore, adds an image-repair.yml workflow, fork-specific README/CONTEXT text, and introduces 12 new open-sse → src imports (the boundary ratchet is at its ceiling). The native image fixes themselves look valuable — please resubmit them as small, focused PRs against release/v3.8.52 without the repository-surface changes. Closing this one. (/merge-batch 2026-10-17)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants