[maxmad64bis]

⚠️ base-red inherited: #15306

Summary

Quality checks that load application modules opened the operator data directory when no data directory was set, so running them on a machine with a live instance applied pending migrations and request-detail rotation to that database and could lock it. Each of the three checks now points at a throwaway data directory when none is chosen and keeps using an explicitly set one, and a new test fails any check that loads application modules without that isolation.

Related Issues

• No linked issue — reproduced on the release base

Target Branch

• Base is the active release/v3.8.x branch (the highest open release/v*), not main
• New feature? From 3.8.55 on it is held with the v4-feature label for the v4 channel

Validation

• Change type: other
• Focused tests and category gates from the golden path
• npm run lint
• Reconciled with the current active release base; focused checks rerun afterward
• Production-code changes include a new or updated automated test in this PR

Tests Added Or Updated

• tests/unit/repo-checks-isolate-datadir.test.ts — runs each check in a subprocess with a fake home directory and asserts the default directory stays untouched, an explicit directory is used as is, blank input counts as unset, the opt-out still resolves the operator directory, and a static-import scan names any unisolated check.

Coverage Notes

• scripts/check/check-known-symbols.ts is covered by the untouched-directory and explicit-directory cases in the new test.
• scripts/check/check-compression-budget.ts is covered by the untouched-directory case and the throwaway-directory probe in the new test.
• scripts/check/check-route-guard-membership.ts is covered by the untouched-directory and explicit-directory cases in the new test.

Reviewer Notes

• Behavior: running a check without a data directory set no longer touches the operator database (before → it opened and migrated it; after → it works in a throwaway directory); setting OMNIROUTE_ALLOW_DEFAULT_DATA_DIR=1 keeps the previous behavior.
• Follow-up: extending the guard to every script run under tsx or bun stays for the maintainer to decide.