Micro Improvement to web tests#2527
Merged
celo-ci-bot-user merged 5 commits intomasterfrom Jan 25, 2020
Merged
Conversation
test functionality of expanding leaderboard
unused since a previous redesign
with added tests 80 is a better target for web, and on mobile the numbers looked way to low
aaronmgdr
commented
Jan 24, 2020
| flags: web | ||
| threshold: 5% | ||
| target: 70% | ||
| threshold: 2% |
Contributor
Author
There was a problem hiding this comment.
from my understanding threshold is how much it can decrease from master before a flag is raised, and target is the absolute amount of lines that need to be tested overall
Codecov Report
@@ Coverage Diff @@
## master #2527 +/- ##
==========================================
- Coverage 73.6% 73.58% -0.03%
==========================================
Files 554 555 +1
Lines 13785 13816 +31
Branches 1425 1425
==========================================
+ Hits 10147 10167 +20
- Misses 3358 3369 +11
Partials 280 280
Continue to review full report at Codecov.
|
Contributor
Yes 😅 👍 |
jmrossy
approved these changes
Jan 24, 2020
aaronmgdr
force-pushed
the
aaronmgdr/more-testing
branch
from
08db32d to
686c8eb
Compare
lucasege
pushed a commit
that referenced
this pull request
Jan 27, 2020
aaronmgdr
added a commit
that referenced
this pull request
Jan 28, 2020
* master: 🧹Web cleanup (readme + static dir) (#2562) Add readable proposals to governance:view command (#2545) Add explicit gas to exchange transactions to prevent errors (#2552) Fix off-by-one error in attributing signatures to blocks in CLI (#2559) ✅ add test for phone Input component (#2554) Add Youtube to Footer + (#2556) Fix rounding error in Election.sol (#2540) [Wallet] Bump @celo/client to 0.0.266 (#2551) [Wallet] E2E test improvements (#2542) Deployed integration (#2550) do not fetch affiliates (#2508) Added more CLI checks for registering validators and groups (#2491) Micro Improvement to web tests (#2527) [Wallet] Prompt users with connectivity issues to switch to forno (#2526) cli: Fix voter rewards presentation (#2543) [Wallet] Fix missing spanish translation (#2539) Downtime slashing when epoch changes (#2436)
lucasege
pushed a commit
that referenced
this pull request
Jun 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
adds test for leaderboard and and abortable fetch
removes old missiontext component
update coverage targets
Tested
Other changes
I changed the target on mobile as 10% seemed way to low.