[Wallet] Prompt users with connectivity issues to switch to forno#2526
[Wallet] Prompt users with connectivity issues to switch to forno#2526
Conversation
| "promptZeroSyncModal": { | ||
| "header": "Cambiar modo de conexión?", | ||
| "body": "Hemos notado que tienes problemas para conectarte. Recomendamos habilitar el modo de ahorro de datos para que pueda seguir usando Celo Wallet con una conexión intermitente.", | ||
| "switchToDataSaver": "Habilitar Data Saver" |
There was a problem hiding this comment.
Once #2539 merges please use Ahorro de Datos here
There was a problem hiding this comment.
Updated translation
| type: Actions.CANCEL_GETH_SAGA, | ||
| }) | ||
|
|
||
| interface SetPromptZeroSync { |
There was a problem hiding this comment.
Nit, I think the name convention we use elsewhere is SetPromptZeroSyncAction, though I guess not in this file for some reason
There was a problem hiding this comment.
Updated all actions in this file to use the normal naming convention
| // Suggest switch to forno for network-related errors | ||
| if (yield select(promptZeroSyncIfNeededSelector)) { | ||
| yield put(setPromptZeroSync(false)) | ||
| navigate(Screens.DataSaver, { promptModalVisible: true }) |
There was a problem hiding this comment.
I assumed we would just enable forno silently in this case. @nityas can you confirm that navigating the user to the Data Saver screen is the desired behavior?
There was a problem hiding this comment.
The user gets navigated to the DataSaver screen with a modal, then once they confirm/decline the switch they go back to wherever they were
There was a problem hiding this comment.
Confirmed with @nityas that this prompt is the expected behavior!
There was a problem hiding this comment.
- confirmed-- it adds a layer of centralization and we do not want to do this without user consent
…epo into annakaz/prompt-forno
…epo into annakaz/prompt-forno
Codecov Report
@@ Coverage Diff @@
## master #2526 +/- ##
========================================
Coverage 73.24% 73.24%
========================================
Files 556 556
Lines 13824 13824
Branches 1722 1425 -297
========================================
Hits 10125 10125
Misses 3418 3418
Partials 281 281
Continue to review full report at Codecov.
|
| yield fork(monitorGeth) | ||
| const gethRelatedSagas = yield all([fork(monitorAppState), fork(monitorGeth)]) | ||
| yield take(Actions.CANCEL_GETH_SAGA) | ||
| yield cancel(gethRelatedSagas) |
There was a problem hiding this comment.
Can you confirm this cancels the individual forks and not just the synthesized one created by all()? If monitorGeth's logs no longer show up after cancel that would confirm it :)
There was a problem hiding this comment.
Yes confirmed that monitorGeth logs go away! Agree that the redux saga cancel all documentation is unclear though (https://redux-saga.js.org/docs/advanced/TaskCancellation.html / outdated post redux-saga/redux-saga#988 (comment))
| geth: { | ||
| initialized: 'INITIALIZED', | ||
| connected: true, | ||
| promptZeroSyncIfNeeded: false, |
There was a problem hiding this comment.
state schema changes, including new additions, need to go in the latest schema (v5 below) since it didn't exist in v-1
…epo into annakaz/prompt-forno
|
Note that build is failing on master due to attestation service (unrelated to this PR) |
* master: 🧹Web cleanup (readme + static dir) (#2562) Add readable proposals to governance:view command (#2545) Add explicit gas to exchange transactions to prevent errors (#2552) Fix off-by-one error in attributing signatures to blocks in CLI (#2559) ✅ add test for phone Input component (#2554) Add Youtube to Footer + (#2556) Fix rounding error in Election.sol (#2540) [Wallet] Bump @celo/client to 0.0.266 (#2551) [Wallet] E2E test improvements (#2542) Deployed integration (#2550) do not fetch affiliates (#2508) Added more CLI checks for registering validators and groups (#2491) Micro Improvement to web tests (#2527) [Wallet] Prompt users with connectivity issues to switch to forno (#2526) cli: Fix voter rewards presentation (#2543) [Wallet] Fix missing spanish translation (#2539) Downtime slashing when epoch changes (#2436)
3 participants
Description
When geth is taking too long to sync (>15 seconds for web3 to sync or seeing connectivity issues with geth), prompt them to turn on forno. Do not prompt if users have already declined to avoid an instrusive experience, and wait to prompt until after they have gone through the welcome screen
Tested
On a pixel 2 by changing sync to take too long and confirming that users are prompted to switch to forno
Other changes
Cancel geth sagas when switching to forno rather than checking within sagas whether forno is enabled
Related issues
Backwards compatibility
Yes