-
Notifications
You must be signed in to change notification settings - Fork 476
Micro Improvement to web tests #2527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7f2c609
:white_check_mark: add test for leaderboard and abortableFetch
aaronmgdr cfbe65b
:fire: remove missionText file
aaronmgdr a2eca3f
:wrench: increase coverage targets on web mobile
aaronmgdr 686c8eb
Keep target just under actual
aaronmgdr 45fdd42
Merge branch 'master' into aaronmgdr/more-testing
aaronmgdr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import { fireEvent, render } from '@testing-library/react' | ||
| import * as React from 'react' | ||
| import LeaderBoard from 'src/dev/LeaderBoard' | ||
|
|
||
| const leaders = new Array(12).fill({ points: 10, identity: 'annie', address: '0x1f3f' }) | ||
|
|
||
| describe('LeaderBoard', () => { | ||
| it('it displays an expand button, and when pressed a "collapse" butto shows', () => { | ||
| const { getByText } = render(<LeaderBoard isLoading={false} leaders={leaders} />) | ||
|
|
||
| fireEvent.click(getByText(/expand/)) | ||
| expect(getByText(/collapse/)).toBeTruthy() | ||
| }) | ||
|
|
||
| it('displays a link to terms', () => { | ||
| const { getByText } = render(<LeaderBoard isLoading={false} leaders={leaders} />) | ||
|
|
||
| expect(getByText(/terms/i).getAttribute('href')).toEqual('/stake-off/terms') | ||
| }) | ||
| }) |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| const fetch = jest.fn() | ||
| jest.mock('cross-fetch', () => fetch) | ||
| import abortableFetch from 'src/utils/abortableFetch' | ||
|
|
||
| describe('abortableFetch', () => { | ||
| it('behaves like fetch', async () => { | ||
| await abortableFetch('with-any-given-url.domain', { method: 'get' }) | ||
| expect(fetch).toHaveBeenCalledWith('with-any-given-url.domain', { method: 'get' }) | ||
| }) | ||
| }) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from my understanding threshold is how much it can decrease from master before a flag is raised, and target is the absolute amount of lines that need to be tested overall