Add readable proposals to governance:view command#2545
Merged
celo-ci-bot-user merged 7 commits intomasterfrom Jan 28, 2020
Merged
Add readable proposals to governance:view command#2545celo-ci-bot-user merged 7 commits intomasterfrom
celo-ci-bot-user merged 7 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2545 +/- ##
==========================================
+ Coverage 73.6% 73.91% +0.31%
==========================================
Files 556 557 +1
Lines 13822 13826 +4
Branches 1364 1661 +297
==========================================
+ Hits 10173 10219 +46
+ Misses 3370 3327 -43
- Partials 279 280 +1
Continue to review full report at Codecov.
|
nambrot
reviewed
Jan 27, 2020
| static flags = { | ||
| ...BaseCommand.flags, | ||
| proposalID: flags.string({ required: true, description: 'UUID of proposal to view' }), | ||
| raw: flags.boolean({ required: false, description: 'Display proposal in raw bytes format' }), |
Contributor
Author
There was a problem hiding this comment.
defaults to false (equivalent to excluding as flag in oclif)
| ) | ||
| async getDequeue() { | ||
| const dequeue = await this.contract.methods.getDequeue().call() | ||
| return dequeue.map(valueToBigNumber).filter((id) => !id.isZero()) |
Contributor
There was a problem hiding this comment.
When would the IDs be zero?
Contributor
Author
There was a problem hiding this comment.
dequeued indices are reused after proposals are deleted (when expired)
the proposalID is set to zero in deleteDequeuedProposal, I will add a comment
asaj
approved these changes
Jan 28, 2020
aaronmgdr
added a commit
that referenced
this pull request
Jan 28, 2020
* master: 🧹Web cleanup (readme + static dir) (#2562) Add readable proposals to governance:view command (#2545) Add explicit gas to exchange transactions to prevent errors (#2552) Fix off-by-one error in attributing signatures to blocks in CLI (#2559) ✅ add test for phone Input component (#2554) Add Youtube to Footer + (#2556) Fix rounding error in Election.sol (#2540) [Wallet] Bump @celo/client to 0.0.266 (#2551) [Wallet] E2E test improvements (#2542) Deployed integration (#2550) do not fetch affiliates (#2508) Added more CLI checks for registering validators and groups (#2491) Micro Improvement to web tests (#2527) [Wallet] Prompt users with connectivity issues to switch to forno (#2526) cli: Fix voter rewards presentation (#2543) [Wallet] Fix missing spanish translation (#2539) Downtime slashing when epoch changes (#2436)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
rawflag togovernance:viewwhich dictates whether proposal should be translated to JSON when outputtedTested
Against
yarn test:livechainOther changes
Adds optional parameters named map to
ProposalTransactionJSONinterfaceRelated issues