Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2542 +/- ##
=======================================
Coverage 73.58% 73.58%
=======================================
Files 555 555
Lines 13816 13816
Branches 1722 1661 -61
=======================================
Hits 10167 10167
- Misses 3369 3370 +1
+ Partials 280 279 -1
Continue to review full report at Codecov.
|
Contributor
jeanregisser
left a comment
jeanregisser
left a comment
There was a problem hiding this comment.
Great improvements!! 👍
Couple of small questions before merging.
| beforeAll(async () => { | ||
| await detox.init(config) | ||
| }) | ||
| }, 300000) |
Contributor
There was a problem hiding this comment.
Nice addition! We should add a comment as to why this is needed.
From what I saw, jest swallows errors or timeouts here and happily continues with executing the test suite though this crucial init failed.
Contributor
Author
There was a problem hiding this comment.
I'm not 100% sure, I'm just aligning this file with the example on Detox's repo
jmrossy
force-pushed
the
rossy/wa-e2e-improvements
branch
from
f302d96 to
034190d
Compare
jeanregisser
approved these changes
Jan 27, 2020
aaronmgdr
added a commit
that referenced
this pull request
Jan 28, 2020
* master: 🧹Web cleanup (readme + static dir) (#2562) Add readable proposals to governance:view command (#2545) Add explicit gas to exchange transactions to prevent errors (#2552) Fix off-by-one error in attributing signatures to blocks in CLI (#2559) ✅ add test for phone Input component (#2554) Add Youtube to Footer + (#2556) Fix rounding error in Election.sol (#2540) [Wallet] Bump @celo/client to 0.0.266 (#2551) [Wallet] E2E test improvements (#2542) Deployed integration (#2550) do not fetch affiliates (#2508) Added more CLI checks for registering validators and groups (#2491) Micro Improvement to web tests (#2527) [Wallet] Prompt users with connectivity issues to switch to forno (#2526) cli: Fix voter rewards presentation (#2543) [Wallet] Fix missing spanish translation (#2539) Downtime slashing when epoch changes (#2436)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tested
Ran e2e tests
Related issues
Backwards compatibility
Yes