Fix off-by-one error in attributing signatures to blocks in CLI#2559
Merged
celo-ci-bot-user merged 5 commits intomasterfrom Jan 28, 2020
Merged
Fix off-by-one error in attributing signatures to blocks in CLI#2559celo-ci-bot-user merged 5 commits intomasterfrom
celo-ci-bot-user merged 5 commits intomasterfrom
Conversation
jfoutts-celo
approved these changes
Jan 28, 2020
Codecov Report
@@ Coverage Diff @@
## master #2559 +/- ##
==========================================
+ Coverage 72.88% 73.91% +1.02%
==========================================
Files 273 557 +284
Lines 5743 13826 +8083
Branches 688 1364 +676
==========================================
+ Hits 4186 10219 +6033
- Misses 1381 3327 +1946
- Partials 176 280 +104
Continue to review full report at Codecov.
|
aaronmgdr
added a commit
that referenced
this pull request
Jan 28, 2020
* master: 🧹Web cleanup (readme + static dir) (#2562) Add readable proposals to governance:view command (#2545) Add explicit gas to exchange transactions to prevent errors (#2552) Fix off-by-one error in attributing signatures to blocks in CLI (#2559) ✅ add test for phone Input component (#2554) Add Youtube to Footer + (#2556) Fix rounding error in Election.sol (#2540) [Wallet] Bump @celo/client to 0.0.266 (#2551) [Wallet] E2E test improvements (#2542) Deployed integration (#2550) do not fetch affiliates (#2508) Added more CLI checks for registering validators and groups (#2491) Micro Improvement to web tests (#2527) [Wallet] Prompt users with connectivity issues to switch to forno (#2526) cli: Fix voter rewards presentation (#2543) [Wallet] Fix missing spanish translation (#2539) Downtime slashing when epoch changes (#2436)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the cli
validator:statusandvalidator:sign-blockscommands use the parent seal of a block to tell whether a validator signed that block. This is incorrect. The parent seal should be used to tell if the validator signed the previous blockTested
Manually CLI testing
Other changes
port-forwardcommand against VMs to select a machineBackwards compatibility
100%