Skip to content

Conversation

@angiejones
Copy link
Collaborator

Summary

CI notes for copilot code review

AI Assistance

  • This PR was created or reviewed with AI assistance

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the GitHub Copilot code review instructions by adding comprehensive CI pipeline context to help Copilot avoid flagging issues that CI will automatically catch.

Key changes:

  • Added detailed "CI Pipeline Context" section explaining what CI checks (formatting, tests, linting, dependencies)
  • Reorganized content to place project context before skip rules for better flow
  • Expanded "Skip These" section with explicit CI-handled items

- `npm run test:run` - Vitest tests

**Setup steps CI performs:**
- Installs system dependencies (libdbus, gnome-keyring, libxcb)
Copy link

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation lists simplified package names (libdbus, libxcb) but CI installs the full -dev package names (libdbus-1-dev, libxcb1-dev). Update to match the actual CI for accuracy: libdbus-1-dev, gnome-keyring, libxcb1-dev.

Suggested change
- Installs system dependencies (libdbus, gnome-keyring, libxcb)
- Installs system dependencies (`libdbus-1-dev`, `gnome-keyring`, `libxcb1-dev`)

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings November 11, 2025 14:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@angiejones angiejones merged commit fb68966 into main Nov 11, 2025
21 checks passed
tlongwell-block added a commit that referenced this pull request Nov 12, 2025
* origin/main: (29 commits)
  chore: Update governance to include Discord (#5690)
  Ollama improvements (#5609)
  feat: add Supabase MCP server to registry (#5629)
  Unlist VS Code extension tutorials from MCP and experimental sections (#5677)
  fix: make image processing work in github copilot provider (#5687)
  fix: do not take into account gitignore in developer mcp (#5688)
  docs: session storage migration (#5682)
  New maintainers (#5685)
  chore: Update governance (#5660)
  chore(release): release version 1.14.0 (minor) (#5676)
  fix : action icons overlap session title in chat history (#5684)
  Document recent goose PRs (#5683)
  docs: add GOOSE_PATH_ROOT environment variable documentation (#5678)
  feat: SessionManager integration for acp sessions (#5657)
  teach copilot our CI (#5672)
  bump openapi version directly (#5674)
  governance: update MAINTAINERS.md to reflect new maintainers (#5675)
  chore: upgrade rmcp to 0.8.5 (#5673)
  Update release instructions (#5662)
  Swapped out to_string_lossy with display for user facing text (#5666)
  ...
michaelneale added a commit that referenced this pull request Nov 13, 2025
* main: (27 commits)
  hackathon banner  (#5710)
  Fix documentation-only change detection for push events (#5712)
  Added transaction commits to multi sql functions in session_manager (#5693)
  fix: improve and simplify tool call chain rendering (#5704)
  Fix: Always show autocompact threshold ui (#5701)
  chore: Update governance to include Discord (#5690)
  Ollama improvements (#5609)
  feat: add Supabase MCP server to registry (#5629)
  Unlist VS Code extension tutorials from MCP and experimental sections (#5677)
  fix: make image processing work in github copilot provider (#5687)
  fix: do not take into account gitignore in developer mcp (#5688)
  docs: session storage migration (#5682)
  New maintainers (#5685)
  chore: Update governance (#5660)
  chore(release): release version 1.14.0 (minor) (#5676)
  fix : action icons overlap session title in chat history (#5684)
  Document recent goose PRs (#5683)
  docs: add GOOSE_PATH_ROOT environment variable documentation (#5678)
  feat: SessionManager integration for acp sessions (#5657)
  teach copilot our CI (#5672)
  ...
Surendhar-N-D pushed a commit to Surendhar-N-D/goose that referenced this pull request Nov 17, 2025
arul-cc pushed a commit to arul-cc/goose that referenced this pull request Nov 17, 2025
BlairAllan pushed a commit to BlairAllan/goose that referenced this pull request Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants