-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: Add functionality to delete session in history list view #4480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
zanesq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works nicely. Couple of nits below
Path Construction:
PathBuf::from(&session_info.path) assumes the path is always valid. If session_info.path is ever malformed or points outside the intended directory, this can be a security risk (path traversal). Can you add sanitizing/validating for the session path?
I noticed there is a line break in the delete confirmation and it flashes the delete confirmation again with delete button active after clicking, can you make it disappear after its done without showing again? (see video).
Kapture.2025-09-02.at.15.12.36.mp4
|
Hi @zanesq, I’ve resolved the requested changes. I removed I also updated the delete confirmation. However, could you please check again and let me know if it’s still happening? Maybe try deleting another chat to see if it reproduces. I’m not sure if it’s a title-related issue. |
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
Signed-off-by: Abhijay007 <Abhijay007j@gmail.com>
ac73bd7 to
c6672b2
Compare
|
Hi @zanesq , can you please try removing :
The |
…e one liner confirmation messages
* main: Align Dynamic Task Interface with Recipe Interface (#4311) docs: copilot auth and mcp-ui links (#4497) docs: July and August 2025 Community All-Stars Update (#4501) remove clicking outside to close recipe warning (#4502) lower min width to 450 for small screens Convert recipe create and import forms to use tanstack form and zod schema validation (#4499) Repo CI: use a writable location for Goose home directory (#4500) feat: Add functionality to delete session in history list view (#4480) fix: recipe deeplink "+" characters and folder change (#4471) Add session to agents (#4216) fix: need to send errors to appropriate stream (#4491) Add Docker support for Goose in CI/CD pipelines (#4434) Add visual indicator while recipe loads (#4447) Disable chat input while extensions load (#4417) chore(release): release version 1.7.0 (#4391) fix double filtering (#4409) Rewrite the developer mcp using the rmcp sdk (#4297) docs: sessions reorg and conversation features (#4462)
* 'main' of github.com:block/goose: Align Dynamic Task Interface with Recipe Interface (#4311) docs: copilot auth and mcp-ui links (#4497) docs: July and August 2025 Community All-Stars Update (#4501) remove clicking outside to close recipe warning (#4502) lower min width to 450 for small screens Convert recipe create and import forms to use tanstack form and zod schema validation (#4499) Repo CI: use a writable location for Goose home directory (#4500) feat: Add functionality to delete session in history list view (#4480) fix: recipe deeplink "+" characters and folder change (#4471) Add session to agents (#4216) fix: need to send errors to appropriate stream (#4491) Add Docker support for Goose in CI/CD pipelines (#4434) Add visual indicator while recipe loads (#4447) Disable chat input while extensions load (#4417) chore(release): release version 1.7.0 (#4391)
…#4480) Signed-off-by: Abhijay007 <Abhijay007j@gmail.com> Co-authored-by: Zane Staggs <zane@squareup.com> Signed-off-by: Matt Donovan <mattddonovan@protonmail.com>
…#4480) Signed-off-by: Abhijay007 <Abhijay007j@gmail.com> Co-authored-by: Zane Staggs <zane@squareup.com> Signed-off-by: HikaruEgashira <hikaru-egashira@c-fo.com>


Closes: #3747
Pull Request Description
This PR introduces session deletion functionality with a confirmation modal in the UI. It replaces the previous IPC approach in the existing PRs with a backend endpoint-based approach (as per Zane’s comment in this PR here: #2803 (comment))
Changes Made
DELETE /sessions/{session_id}/deleteendpoint with secure validationSessionListViewwith a confirmation modal for deletionPreview