Skip to content

Conversation

@atishpatel
Copy link
Contributor

@atishpatel atishpatel commented Sep 1, 2025

Pull Request Description

  1. Deep links with "+" characters where failing due to the url decoding logic. This PR fixes that issue by grabbing the deep link directly from the url if the decoded deeplink doesn't match

before:

[Main] Received open-url event: goose://recipe?config=...WNpcGU+YC5cbiA
...
[Main] Creating window with recipe loading state for deeplink: ...WNpcGU YC5cbi // "+" is replaced by " " space

after:

[Main] Received open-url event: goose://recipe?config=...WNpcGU+YC5cbiA
...
[Main] Creating window with recipe loading state for deeplink: ...WNpcGU+YC5cbi
  1. Preserve deeplink if folder is changed

Behavior before:
Open deeplink -> new window opens -> realize folder is wrong so change folder -> new window opens -> need to click deeplink again -> new window with recipe and correct folder

New behavior:
Open deeplink -> new window opens -> realize folder is wrong so change folder -> new window with recipe and correct folder

Copy link
Collaborator

@zanesq zanesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One thing can you add a comment to explain why this workaround is needed (e.g., “URLSearchParams decodes + as space, which can break encoded configs”).

@atishpatel
Copy link
Contributor Author

Thanks Zane! Pulled into separate function and added your suggested comment

@atishpatel atishpatel changed the title fix: enhance recipe deeplink to handle "+" characters fix: recipe deeplink "+" characters and folder change Sep 2, 2025
@zanesq zanesq merged commit 1b59d12 into block:main Sep 3, 2025
10 checks passed
michaelneale added a commit that referenced this pull request Sep 3, 2025
* main:
  Align Dynamic Task Interface with Recipe Interface (#4311)
  docs: copilot auth and mcp-ui links (#4497)
  docs: July and August 2025 Community All-Stars Update (#4501)
  remove clicking outside to close recipe warning (#4502)
  lower min width to 450 for small screens
  Convert recipe create and import forms to use tanstack form and zod schema validation (#4499)
  Repo CI: use a writable location for Goose home directory (#4500)
  feat: Add functionality to delete session in history list view (#4480)
  fix: recipe deeplink "+" characters and folder change (#4471)
  Add session to agents (#4216)
  fix: need to send errors to appropriate stream (#4491)
  Add Docker support for Goose in CI/CD pipelines (#4434)
  Add visual indicator while recipe loads (#4447)
  Disable chat input while extensions load (#4417)
  chore(release): release version 1.7.0 (#4391)
  fix double filtering (#4409)
  Rewrite the developer mcp using the rmcp sdk (#4297)
  docs: sessions reorg and conversation features (#4462)
katzdave added a commit that referenced this pull request Sep 4, 2025
* 'main' of github.com:block/goose:
  Align Dynamic Task Interface with Recipe Interface (#4311)
  docs: copilot auth and mcp-ui links (#4497)
  docs: July and August 2025 Community All-Stars Update (#4501)
  remove clicking outside to close recipe warning (#4502)
  lower min width to 450 for small screens
  Convert recipe create and import forms to use tanstack form and zod schema validation (#4499)
  Repo CI: use a writable location for Goose home directory (#4500)
  feat: Add functionality to delete session in history list view (#4480)
  fix: recipe deeplink "+" characters and folder change (#4471)
  Add session to agents (#4216)
  fix: need to send errors to appropriate stream (#4491)
  Add Docker support for Goose in CI/CD pipelines (#4434)
  Add visual indicator while recipe loads (#4447)
  Disable chat input while extensions load (#4417)
  chore(release): release version 1.7.0 (#4391)
This was referenced Sep 9, 2025
thebristolsound pushed a commit to thebristolsound/goose that referenced this pull request Sep 11, 2025
HikaruEgashira pushed a commit to HikaruEgashira/goose that referenced this pull request Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants