Skip to content

Conversation

@amed-xyz
Copy link
Collaborator

@amed-xyz amed-xyz commented Aug 29, 2025

Follow up from #4412

Initiating a chat conversation while extensions are still loading can cause unexpected behaviour. This is for disabling the chat input while on loading state.

@amed-xyz amed-xyz self-assigned this Aug 29, 2025
@amed-xyz amed-xyz marked this pull request as ready for review August 29, 2025 17:34
@amed-xyz amed-xyz force-pushed the amed/disable-input-on-boot branch from 7985634 to f32a775 Compare August 29, 2025 18:58
@amed-xyz amed-xyz requested a review from zanesq August 29, 2025 19:29
Copy link
Collaborator

@zanesq zanesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM but when I run this branch it seems everything is frozen. I can't click on chat or any navigation and can't bring up the browser dev tools. It doesn't happen on main. Maybe pull in main again to see if it fixes it?

@amed-xyz amed-xyz force-pushed the amed/disable-input-on-boot branch from 649a9d0 to fb300b0 Compare September 2, 2025 19:57
@amed-xyz
Copy link
Collaborator Author

amed-xyz commented Sep 2, 2025

@zanesq good catch, !hasSubmittableContent was preventing the textarea from ever becoming enabled. I've updated the branch with latest master and committed a fix

Copy link
Collaborator

@zanesq zanesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working with latest!

@amed-xyz amed-xyz merged commit 4e9c5e3 into main Sep 2, 2025
11 checks passed
@amed-xyz amed-xyz deleted the amed/disable-input-on-boot branch September 2, 2025 21:03
michaelneale added a commit that referenced this pull request Sep 3, 2025
* main:
  Align Dynamic Task Interface with Recipe Interface (#4311)
  docs: copilot auth and mcp-ui links (#4497)
  docs: July and August 2025 Community All-Stars Update (#4501)
  remove clicking outside to close recipe warning (#4502)
  lower min width to 450 for small screens
  Convert recipe create and import forms to use tanstack form and zod schema validation (#4499)
  Repo CI: use a writable location for Goose home directory (#4500)
  feat: Add functionality to delete session in history list view (#4480)
  fix: recipe deeplink "+" characters and folder change (#4471)
  Add session to agents (#4216)
  fix: need to send errors to appropriate stream (#4491)
  Add Docker support for Goose in CI/CD pipelines (#4434)
  Add visual indicator while recipe loads (#4447)
  Disable chat input while extensions load (#4417)
  chore(release): release version 1.7.0 (#4391)
  fix double filtering (#4409)
  Rewrite the developer mcp using the rmcp sdk (#4297)
  docs: sessions reorg and conversation features (#4462)
katzdave added a commit that referenced this pull request Sep 4, 2025
* 'main' of github.com:block/goose:
  Align Dynamic Task Interface with Recipe Interface (#4311)
  docs: copilot auth and mcp-ui links (#4497)
  docs: July and August 2025 Community All-Stars Update (#4501)
  remove clicking outside to close recipe warning (#4502)
  lower min width to 450 for small screens
  Convert recipe create and import forms to use tanstack form and zod schema validation (#4499)
  Repo CI: use a writable location for Goose home directory (#4500)
  feat: Add functionality to delete session in history list view (#4480)
  fix: recipe deeplink "+" characters and folder change (#4471)
  Add session to agents (#4216)
  fix: need to send errors to appropriate stream (#4491)
  Add Docker support for Goose in CI/CD pipelines (#4434)
  Add visual indicator while recipe loads (#4447)
  Disable chat input while extensions load (#4417)
  chore(release): release version 1.7.0 (#4391)
This was referenced Sep 9, 2025
thebristolsound pushed a commit to thebristolsound/goose that referenced this pull request Sep 11, 2025
Signed-off-by: Matt Donovan <mattddonovan@protonmail.com>
HikaruEgashira pushed a commit to HikaruEgashira/goose that referenced this pull request Oct 3, 2025
Signed-off-by: HikaruEgashira <hikaru-egashira@c-fo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants