Rewrite the developer mcp using the rmcp sdk #4297

angelahning · 2025-08-22T20:18:26Z

This is part 1 of moving the developer extension to using the official rmcp sdk instead of our custom sdk. All the functionalities of the og developer tools have been reimplemented (thanks AI) along with all the existing tests.

Tested the new server with the mcp inspector and the tools are working
npx --registry https://registry.npmjs.org @modelcontextprotocol/inspector cargo run -p goose-server --bin goosed -- mcp rmcp_developer

This is not used by anything yet. Second PR incoming, where I actually swap the client.

The rmcp developer is missing the prompts and streaming feature, but i will add them before swapping the clients.

jamadeo · 2025-08-25T12:56:38Z

Nice! I hadn't thought of implementing it as a "new" extension, but this does make it easy to run side-by-side. One thing we could do here is add some cases to the mcp integration tests for the old and new implementation and compare the recorded interaction.

One risk that we'll need to watch out for is someone else making changes to developer that don't get flagged as conflicts and instead end up silently dropped though.

crates/goose-server/src/commands/mcp.rs

angelahning · 2025-08-27T03:17:40Z

Nice! I hadn't thought of implementing it as a "new" extension, but this does make it easy to run side-by-side. One thing we could do here is add some cases to the mcp integration tests for the old and new implementation and compare the recorded interaction.

One risk that we'll need to watch out for is someone else making changes to developer that don't get flagged as conflicts and instead end up silently dropped though.

added integration tests!

yeah agreed that is a risk. But I thought it'd be easier to re-write it instead of modifying this 4000 line file in place... Hopefully there won't be too many changes til I swap the clients.

DOsinga · 2025-08-27T03:22:28Z

yeah agreed that is a risk. But I thought it'd be easier to re-write it instead of modifying this 4000 line file in place... Hopefully there won't be too many changes til I swap the clients.

FWIW I have a small change pending on how we do the prompt for windows vs non windows - extracting the communalities and also pointing out to the agent to use / even in windows since C:\new\table will mostly be converted to something with a newline and a tab in it. Let's keep that in mind

jamadeo

Nice.

Yeah given what Douwe is saying and that there might be PRs referencing the existing developer extension, it is probably better to just delete the old implementation along with adding this one.

jamadeo · 2025-08-27T16:20:08Z

crates/goose/tests/mcp_integration_test.rs

+    vec![
+        ToolCall::new("text_editor", json!({
+            "command": "view",
+            "path": "/Users/aning/goose/crates/goose/tests/tmp/goose.txt"


probably don't want to use these paths -- you could have the tool first create a file and operate on that

crates/goose-mcp/src/developer/rmcp_developer.rs

jamadeo · 2025-08-27T18:51:31Z

crates/goose-mcp/src/developer/rmcp_developer.rs

+            let stdout = SplitStream::new(stdout.split(b'\n')).map(|v| ("stdout", v));
+            let stderr = SplitStream::new(stderr.split(b'\n')).map(|v| ("stderr", v));
+            let mut merged = stdout.merge(stderr);
+


this seems to have lost the output streaming we did using notifications that the prior tool had:

goose/crates/goose-mcp/src/developer/mod.rs

Lines 645 to 661 in 9b9e6d9

notifier

.try_send(JsonRpcMessage::Notification(JsonRpcNotification {

jsonrpc: JsonRpcVersion2_0,

notification: Notification {

method: "notifications/message".to_string(),

params: object!({

"level": "info",

"data": {

"type": "shell",

"stream": key,

"output": line,

}

}),

extensions: Default::default(),

},

}))

.ok();

for this you'd need a reference to the Peer (client). I'm not sure if the #[tool] annotated functions provide that, but it should be possible using call_tool

@jamadeo I added streaming notifications back! see below

This reverts commit 6807b6d.

Signed-off-by: Carine Bruyndoncx <[email protected]>

michaelneale · 2025-09-03T02:16:48Z

crates/goose-server/src/commands/mcp.rs


    tracing::info!("Starting MCP server");
+
+    if name == "developer" {


??? why is this one different now? this seems a lot more complicated than the old router?

michaelneale · 2025-09-03T02:18:56Z

hrm - there are quite a lot of changes in here, main one is how it handles errors is quite different and will break functionality. Also the DeveloperRouter -> DeveloperServer - is that a change that has to be repeated everywhere?

michaelneale · 2025-09-03T02:19:22Z

crates/goose-cli/src/commands/mcp.rs


    tracing::info!("Starting MCP server");

+    if name == "developer" {


seems a lot uglier than before...

michaelneale · 2025-09-03T02:53:10Z

crates/goose-mcp/Cargo.toml

 mcp-core = { path = "../mcp-core" }
 mcp-server = { path = "../mcp-server" }
-rmcp = { workspace = true }
+rmcp = { version = "0.6.0", features = ["server", "client", "transport-io", "macros"] }


this should be set at parent, not here

* main: Align Dynamic Task Interface with Recipe Interface (#4311) docs: copilot auth and mcp-ui links (#4497) docs: July and August 2025 Community All-Stars Update (#4501) remove clicking outside to close recipe warning (#4502) lower min width to 450 for small screens Convert recipe create and import forms to use tanstack form and zod schema validation (#4499) Repo CI: use a writable location for Goose home directory (#4500) feat: Add functionality to delete session in history list view (#4480) fix: recipe deeplink "+" characters and folder change (#4471) Add session to agents (#4216) fix: need to send errors to appropriate stream (#4491) Add Docker support for Goose in CI/CD pipelines (#4434) Add visual indicator while recipe loads (#4447) Disable chat input while extensions load (#4417) chore(release): release version 1.7.0 (#4391) fix double filtering (#4409) Rewrite the developer mcp using the rmcp sdk (#4297) docs: sessions reorg and conversation features (#4462)

Signed-off-by: Matt Donovan <[email protected]>

Signed-off-by: HikaruEgashira <[email protected]>

angelahning force-pushed the aning/tc branch from 366aa20 to d44bcf1 Compare August 22, 2025 20:20

jamadeo reviewed Aug 25, 2025

View reviewed changes

crates/goose-server/src/commands/mcp.rs Outdated Show resolved Hide resolved

angelahning force-pushed the aning/tc branch 5 times, most recently from 4f4b29f to f26cdb3 Compare August 27, 2025 02:40

angelahning marked this pull request as ready for review August 27, 2025 02:42

angelahning force-pushed the aning/tc branch from f26cdb3 to ce7e9c7 Compare August 27, 2025 03:05

angelahning force-pushed the aning/tc branch from ce7e9c7 to f17be92 Compare August 27, 2025 03:20

jamadeo approved these changes Aug 27, 2025

View reviewed changes

jamadeo reviewed Aug 27, 2025

View reviewed changes

shawn111 mentioned this pull request Aug 28, 2025

chore: Bump xcap to 0.7.0, let android can cargo build without extra patch #4344

Closed

This comment was marked as off-topic.

Sign in to view

angelahning added 13 commits August 29, 2025 12:48

boilerplate

ec2355e

list window tool

af8bc4f

screen capture

a34d1e7

migrate the text editor tool

edd3ab5

add remaining tools

59b2c1d

add base instructions

3ba887f

add mcp command

87dce59

add ai text editor

c557a9b

port over the tests

deb4fcc

add integration tests

e2b6942

fmt

483709e

remove duplicate code

4f55772

extract text editor helpers

3f5a565

angelahning added 4 commits August 29, 2025 12:48

support prompts

4ce3e0c

disable og developer

6a1051c

support notification

7823f10

swap developer

82de222

angelahning force-pushed the aning/tc branch from f17be92 to 82de222 Compare August 29, 2025 16:49

angelahning added 2 commits August 29, 2025 12:54

remove old developer extension

c59fc16

update tests

1dc5cb7

angelahning force-pushed the aning/tc branch from 54f019d to 01e40e8 Compare August 29, 2025 19:23

fix lint

62fa3cc

angelahning force-pushed the aning/tc branch from 01e40e8 to 62fa3cc Compare August 29, 2025 19:34

angelahning added 5 commits August 29, 2025 15:48

support ai editor models

3de12e7

add os specific instructions

d0bf4ee

update test

2269af8

remove comments

3586182

lint error

8288c93

angelahning merged commit 6807b6d into main Sep 2, 2025
11 checks passed

angelahning deleted the aning/tc branch September 2, 2025 15:24

angelahning added a commit that referenced this pull request Sep 2, 2025

Revert "Rewrite the developer mcp using the rmcp sdk (#4297)"

7ef2f6b

This reverts commit 6807b6d.

cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Sep 2, 2025

Rewrite the developer mcp using the rmcp sdk (block#4297)

273c9aa

Signed-off-by: Carine Bruyndoncx <[email protected]>

alexhancock mentioned this pull request Sep 2, 2025

feat(rmcp-conversion): mcp server conversions #4488

Closed

michaelneale reviewed Sep 3, 2025

View reviewed changes

This was referenced Sep 9, 2025

chore(release): release version 1.8.0 #4572

Closed

release/1.8.0 #4577

Merged

thebristolsound pushed a commit to thebristolsound/goose that referenced this pull request Sep 11, 2025

Rewrite the developer mcp using the rmcp sdk (block#4297)

41a9580

Signed-off-by: Matt Donovan <[email protected]>

HikaruEgashira pushed a commit to HikaruEgashira/goose that referenced this pull request Oct 3, 2025

Rewrite the developer mcp using the rmcp sdk (block#4297)

4ab835e

Signed-off-by: HikaruEgashira <[email protected]>

clouatre mentioned this pull request Dec 23, 2025

CLI shell output streaming too verbose in v1.18.0 #6216

Open

	notifier
	.try_send(JsonRpcMessage::Notification(JsonRpcNotification {
	jsonrpc: JsonRpcVersion2_0,
	notification: Notification {
	method: "notifications/message".to_string(),
	params: object!({
	"level": "info",
	"data": {
	"type": "shell",
	"stream": key,
	"output": line,
	}
	}),
	extensions: Default::default(),
	},
	}))
	.ok();


		tracing::info!("Starting MCP server");

		if name == "developer" {

Rewrite the developer mcp using the rmcp sdk #4297

Rewrite the developer mcp using the rmcp sdk #4297

Conversation

angelahning commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jamadeo commented Aug 25, 2025

Uh oh!

Uh oh!

angelahning commented Aug 27, 2025

Uh oh!

DOsinga commented Aug 27, 2025

Uh oh!

jamadeo left a comment

Choose a reason for hiding this comment

Uh oh!

jamadeo Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jamadeo Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

angelahning Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as off-topic.

Uh oh!

michaelneale Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

michaelneale commented Sep 3, 2025

Uh oh!

michaelneale Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

michaelneale Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

angelahning commented Aug 22, 2025 •

edited

Loading

angelahning Aug 29, 2025 •

edited

Loading