fix double filtering #4409
Merged
fix double filtering #4409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kvadratni
force-pushed
the
mnovich/improve-recipe-telemetry-UI
branch
from
ad2afbd to
862b87b
Compare
DOsinga
approved these changes
Aug 29, 2025
| .unwrap_or_else(|| id.clone()), | ||
| Err(_) => id.clone(), | ||
| }; | ||
| .unwrap_or_else(|| id.clone()); |
Collaborator
There was a problem hiding this comment.
should we just use the name of recipe, rather than basing something on the filename?
Contributor
Author
There was a problem hiding this comment.
I was contemplating it. but we do use the filename as a more unique indicator. I can have 7 recipes with the same title, but filenames will be unique
Collaborator
There was a problem hiding this comment.
I dont want to be difficult here, but the variable is called recipe_display_name, so showing the name of the recipe seems kinda reasonable. the plan is to merge recipes and scheduler either way and do away with the extra naming layers we have everywhere, fwiw
Contributor
Author
There was a problem hiding this comment.
ah good to know. Can we just leave this until then to avoid redundant work?
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Sep 2, 2025
Signed-off-by: Carine Bruyndoncx <bruyndoncx@gmail.com>
michaelneale
added a commit
that referenced
this pull request
Sep 3, 2025
* main: Align Dynamic Task Interface with Recipe Interface (#4311) docs: copilot auth and mcp-ui links (#4497) docs: July and August 2025 Community All-Stars Update (#4501) remove clicking outside to close recipe warning (#4502) lower min width to 450 for small screens Convert recipe create and import forms to use tanstack form and zod schema validation (#4499) Repo CI: use a writable location for Goose home directory (#4500) feat: Add functionality to delete session in history list view (#4480) fix: recipe deeplink "+" characters and folder change (#4471) Add session to agents (#4216) fix: need to send errors to appropriate stream (#4491) Add Docker support for Goose in CI/CD pipelines (#4434) Add visual indicator while recipe loads (#4447) Disable chat input while extensions load (#4417) chore(release): release version 1.7.0 (#4391) fix double filtering (#4409) Rewrite the developer mcp using the rmcp sdk (#4297) docs: sessions reorg and conversation features (#4462)
This was referenced Sep 9, 2025
Merged
thebristolsound
pushed a commit
to thebristolsound/goose
that referenced
this pull request
Sep 11, 2025
Signed-off-by: Matt Donovan <mattddonovan@protonmail.com>
HikaruEgashira
pushed a commit
to HikaruEgashira/goose
that referenced
this pull request
Oct 3, 2025
Signed-off-by: HikaruEgashira <hikaru-egashira@c-fo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
fix for comment in
https://github.com/block/goose/pull/4399/files/d0a11254837dc7d7eb5a2299292a07a33803c24c#r2308781571