-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Speed up app initialization and improve refresh crashing #3717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…llelizing requests. Also added more guards for localstorage not available to help with refresh crashing issues.
|
very nice, startup could be much faster, don't quite understand all the changes but worth a look - probably worth testing by hand when bundled/signed too. |
ui/desktop/index.html
Outdated
| } else { | ||
| document.documentElement.classList.remove('dark'); | ||
| try { | ||
| if (typeof Storage !== 'undefined' && window.localStorage) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when would storage be undefined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it can be undefined in older browsers or if localstorage is disabled so its just a check that its available before running localstorage operations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be in a pretty bad state if we hit that in the electron app though wouldn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I am also a bit confused on this point. Wouldn't electron bundle the APIs being used, so it would either be defined or not in a given implementation?
I'm not against checking, but just wondering if it could ever catch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, wasn't really needed removed!
* main: Increase req body limit (#2965) Stable goose info -v (#3760) Speed up app initialization and improve refresh crashing (#3717) docs: consolidate search session content, doc import recipe (#3759) Improve power save blocker mechanism (#3698) Ensure adding/removing extensions refreshes extensions list (#3695) Env parsing for primitive types (#3706) Autocompact + One Shot Summarization algorithm (#3559) fix: initial prompt not filled in after accepting new recipe (#3637) fix not being able to click on searchbar buttons in chat (#3723) center session summary modal description text (#3737) Persist first message to local history in case of failure or cancellation (#3744) Make the client more secure (#3742) feat: Allow configuring hints filename(s) (#3269) Add support for mouse back nav button to Settings screen (#3195) chore: Remove the wrong tailwind package (#3754) chore: fix typo in desktop readme for goosed (#3752) feat: upgrade rmcp (#3738) feat: allow users view and edit their non-secret config's (#3005) fix: View extensions link (#3751)
* main: fix: don't return full shell output when very large (#3750) fix: cli tool logging (#3749) Increase req body limit (#2965) Stable goose info -v (#3760) Speed up app initialization and improve refresh crashing (#3717) docs: consolidate search session content, doc import recipe (#3759) Improve power save blocker mechanism (#3698) Ensure adding/removing extensions refreshes extensions list (#3695) Env parsing for primitive types (#3706) Autocompact + One Shot Summarization algorithm (#3559)
Speed up app initialization by only checking cost if enabled and parallelizing initialization requests.
Also added more guards for localstorage not available to help with refresh crashing issues.