Skip to content

Conversation

@zanesq
Copy link
Collaborator

@zanesq zanesq commented Jul 29, 2025

Speed up app initialization by only checking cost if enabled and parallelizing initialization requests.

Also added more guards for localstorage not available to help with refresh crashing issues.

VM8:16 Failed to access localStorage: SecurityError: Failed to read the 'localStorage' property from 'Window': Access is denied for this document.
(anonymous) @ VM8:16
VM8:22 Failed to set localStorage after retry: SecurityError: Failed to read the 'localStorage' property from 'Window': Access is denied for this document.
(anonymous) @ VM8:22
chromewebdata/:1 Not allowed to load local resource: file:///pair

zanesq and others added 2 commits July 29, 2025 11:20
…llelizing requests. Also added more guards for localstorage not available to help with refresh crashing issues.
@michaelneale
Copy link
Collaborator

michaelneale commented Jul 30, 2025

very nice, startup could be much faster, don't quite understand all the changes but worth a look - probably worth testing by hand when bundled/signed too.

} else {
document.documentElement.classList.remove('dark');
try {
if (typeof Storage !== 'undefined' && window.localStorage) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when would storage be undefined?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can be undefined in older browsers or if localstorage is disabled so its just a check that its available before running localstorage operations

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be in a pretty bad state if we hit that in the electron app though wouldn't it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I am also a bit confused on this point. Wouldn't electron bundle the APIs being used, so it would either be defined or not in a given implementation?

I'm not against checking, but just wondering if it could ever catch.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, wasn't really needed removed!

@zanesq zanesq merged commit 3f6a055 into main Jul 31, 2025
8 of 9 checks passed
@zanesq zanesq deleted the zane/ui-initialization-speed branch July 31, 2025 19:41
michaelneale added a commit that referenced this pull request Jul 31, 2025
* main:
  Increase req body limit (#2965)
  Stable goose info -v (#3760)
  Speed up app initialization and improve refresh crashing (#3717)
  docs: consolidate search session content, doc import recipe (#3759)
  Improve power save blocker mechanism (#3698)
  Ensure adding/removing extensions refreshes extensions list (#3695)
  Env parsing for primitive types (#3706)
  Autocompact + One Shot Summarization algorithm (#3559)
  fix: initial prompt not filled in after accepting new recipe (#3637)
  fix not being able to click on searchbar buttons in chat (#3723)
  center session summary modal description text (#3737)
  Persist first message to local history in case of failure or cancellation (#3744)
  Make the client more secure (#3742)
  feat: Allow configuring hints filename(s) (#3269)
  Add support for mouse back nav button to Settings screen (#3195)
  chore: Remove the wrong tailwind package (#3754)
  chore: fix typo in desktop readme for goosed (#3752)
  feat: upgrade rmcp (#3738)
  feat: allow users view and edit their non-secret config's (#3005)
  fix: View extensions link (#3751)
michaelneale added a commit that referenced this pull request Aug 1, 2025
* main:
  fix: don't return full shell output when very large (#3750)
  fix: cli tool logging (#3749)
  Increase req body limit (#2965)
  Stable goose info -v (#3760)
  Speed up app initialization and improve refresh crashing (#3717)
  docs: consolidate search session content, doc import recipe (#3759)
  Improve power save blocker mechanism (#3698)
  Ensure adding/removing extensions refreshes extensions list (#3695)
  Env parsing for primitive types (#3706)
  Autocompact + One Shot Summarization algorithm (#3559)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants