-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: upgrade rmcp #3738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: upgrade rmcp #3738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated workspace dependency in Cargo.toml - Fixed breaking changes from schemars 0.8.x to 1.0.4 upgrade - Rewrote OpenAPI schema conversion to use public schemars API - All tests pass and code compiles successfully The schemars upgrade made the schema module private, requiring a complete rewrite of the schema conversion functions to work with JSON values directly instead of internal schema types.
- Added missing schema definitions for RawTextContent, RawImageContent, and RawEmbeddedResource - Added Annotated schema definition to resolve missing pointer - Updated imports to include all necessary rmcp model types - Fixed schema conversion to handle the new rmcp content type structure The rmcp upgrade from 0.2.1 to 0.3.1 restructured content types, requiring additional schema definitions to be generated for the raw content types that are referenced by the Content enum but weren't being included in the OpenAPI schema generation.
aharvard
commented
Jul 30, 2025
- Reorder imports alphabetically in openapi.rs - Fix line formatting for function calls - Fix Prettier formatting in FlyingBird.tsx - Resolves CI formatting check failures
Collaborator
Author
|
@alexhancock, ready for review! |
alexhancock
approved these changes
Jul 31, 2025
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
katzdave
added a commit
that referenced
this pull request
Jul 31, 2025
* 'main' of github.com:block/goose: feat: Allow configuring hints filename(s) (#3269) Add support for mouse back nav button to Settings screen (#3195) chore: Remove the wrong tailwind package (#3754) chore: fix typo in desktop readme for goosed (#3752) feat: upgrade rmcp (#3738) feat: allow users view and edit their non-secret config's (#3005) fix: View extensions link (#3751) chord: refactor tool route (#3732)
michaelneale
added a commit
that referenced
this pull request
Jul 31, 2025
* main: Increase req body limit (#2965) Stable goose info -v (#3760) Speed up app initialization and improve refresh crashing (#3717) docs: consolidate search session content, doc import recipe (#3759) Improve power save blocker mechanism (#3698) Ensure adding/removing extensions refreshes extensions list (#3695) Env parsing for primitive types (#3706) Autocompact + One Shot Summarization algorithm (#3559) fix: initial prompt not filled in after accepting new recipe (#3637) fix not being able to click on searchbar buttons in chat (#3723) center session summary modal description text (#3737) Persist first message to local history in case of failure or cancellation (#3744) Make the client more secure (#3742) feat: Allow configuring hints filename(s) (#3269) Add support for mouse back nav button to Settings screen (#3195) chore: Remove the wrong tailwind package (#3754) chore: fix typo in desktop readme for goosed (#3752) feat: upgrade rmcp (#3738) feat: allow users view and edit their non-secret config's (#3005) fix: View extensions link (#3751)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading rmcp crate