Skip to content

Conversation

@aharvard
Copy link
Collaborator

@aharvard aharvard commented Jul 30, 2025

Upgrading rmcp crate

aharvard added 2 commits July 30, 2025 10:33
- Updated workspace dependency in Cargo.toml
- Fixed breaking changes from schemars 0.8.x to 1.0.4 upgrade
- Rewrote OpenAPI schema conversion to use public schemars API
- All tests pass and code compiles successfully

The schemars upgrade made the schema module private, requiring a complete
rewrite of the schema conversion functions to work with JSON values directly
instead of internal schema types.
- Added missing schema definitions for RawTextContent, RawImageContent, and RawEmbeddedResource
- Added Annotated schema definition to resolve missing  pointer
- Updated imports to include all necessary rmcp model types
- Fixed schema conversion to handle the new rmcp content type structure

The rmcp upgrade from 0.2.1 to 0.3.1 restructured content types, requiring
additional schema definitions to be generated for the raw content types that
are referenced by the Content enum but weren't being included in the OpenAPI
schema generation.
aharvard added 3 commits July 30, 2025 16:13
- Reorder imports alphabetically in openapi.rs
- Fix line formatting for function calls
- Fix Prettier formatting in FlyingBird.tsx
- Resolves CI formatting check failures
@aharvard
Copy link
Collaborator Author

@alexhancock, ready for review!

Copy link
Collaborator

@alexhancock alexhancock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@alexhancock alexhancock merged commit 001bceb into block:main Jul 31, 2025
8 checks passed
katzdave added a commit that referenced this pull request Jul 31, 2025
* 'main' of github.com:block/goose:
  feat: Allow configuring hints filename(s) (#3269)
  Add support for mouse back nav button to Settings screen (#3195)
  chore: Remove the wrong tailwind package (#3754)
  chore: fix typo in desktop readme for goosed (#3752)
  feat: upgrade rmcp (#3738)
  feat: allow users view and edit their non-secret config's (#3005)
  fix: View extensions link (#3751)
  chord: refactor tool route (#3732)
michaelneale added a commit that referenced this pull request Jul 31, 2025
* main:
  Increase req body limit (#2965)
  Stable goose info -v (#3760)
  Speed up app initialization and improve refresh crashing (#3717)
  docs: consolidate search session content, doc import recipe (#3759)
  Improve power save blocker mechanism (#3698)
  Ensure adding/removing extensions refreshes extensions list (#3695)
  Env parsing for primitive types (#3706)
  Autocompact + One Shot Summarization algorithm (#3559)
  fix: initial prompt not filled in after accepting new recipe (#3637)
  fix not being able to click on searchbar buttons in chat (#3723)
  center session summary modal description text (#3737)
  Persist first message to local history in case of failure or cancellation (#3744)
  Make the client more secure (#3742)
  feat: Allow configuring hints filename(s) (#3269)
  Add support for mouse back nav button to Settings screen (#3195)
  chore: Remove the wrong tailwind package (#3754)
  chore: fix typo in desktop readme for goosed (#3752)
  feat: upgrade rmcp (#3738)
  feat: allow users view and edit their non-secret config's (#3005)
  fix: View extensions link (#3751)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants