Improve power save blocker mechanism #3698
Conversation
…minutes of inactivity and have per window ids for better cleanup
| const timeoutId = window.setTimeout( | ||
| () => { | ||
| console.warn('Power save blocker timeout - stopping automatically after 15 minutes'); | ||
| stopPowerSaveBlocker(); |
There was a problem hiding this comment.
What's the intention of the power save blocker? Do we have it so that people can walk away from their computers for long periods of time and have goose continue to work? In which case we may not want to turn it off after 15 mins of inactivity?
There was a problem hiding this comment.
yes was exactly that - as sleep comes soon for some setups but you want it to run just a bit longer. I don't know how widely it is used and I would be ok if it made sense to retire it (this predates schedules and recipes and headless and all these other things) but then again, may still be relevant.
There was a problem hiding this comment.
Should have put more details in the original description. The reason I added this is PCI requirements state that the screen should auto lock after 15 mins of user inactivity and the power save blocker was stopping the screen from locking. Also added logic to make sure its actually tracked/stopped in other windows.
…ne/power-save-blocker * origin/zane/power-save-blocker: Remove unneeded comment
* main: Increase req body limit (#2965) Stable goose info -v (#3760) Speed up app initialization and improve refresh crashing (#3717) docs: consolidate search session content, doc import recipe (#3759) Improve power save blocker mechanism (#3698) Ensure adding/removing extensions refreshes extensions list (#3695) Env parsing for primitive types (#3706) Autocompact + One Shot Summarization algorithm (#3559) fix: initial prompt not filled in after accepting new recipe (#3637) fix not being able to click on searchbar buttons in chat (#3723) center session summary modal description text (#3737) Persist first message to local history in case of failure or cancellation (#3744) Make the client more secure (#3742) feat: Allow configuring hints filename(s) (#3269) Add support for mouse back nav button to Settings screen (#3195) chore: Remove the wrong tailwind package (#3754) chore: fix typo in desktop readme for goosed (#3752) feat: upgrade rmcp (#3738) feat: allow users view and edit their non-secret config's (#3005) fix: View extensions link (#3751)
* main: fix: don't return full shell output when very large (#3750) fix: cli tool logging (#3749) Increase req body limit (#2965) Stable goose info -v (#3760) Speed up app initialization and improve refresh crashing (#3717) docs: consolidate search session content, doc import recipe (#3759) Improve power save blocker mechanism (#3698) Ensure adding/removing extensions refreshes extensions list (#3695) Env parsing for primitive types (#3706) Autocompact + One Shot Summarization algorithm (#3559)
change power save blocker to automatically stop and cleanup after 15 minutes of inactivity and have per window ids for better cleanup